Skip to content

Does this actually work to drop javascript? #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
BryanQuigley wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Does this actually work to drop javascript? #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6cda18
Does this actually work to drop javascript?
BryanQuigley May 18, 2026
c843a67
Fully move to one file for datasets page and migrate to bootstrap CDN
BryanQuigley May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions _includes/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
<!-- general behavior -->
<script type="module" src="{{ site.baseurl }}/scripts/dist/index.js"></script>

<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.3.3/dist/js/bootstrap.bundle.min.js" integrity="sha384-YvpcrYf0tY3lHB60NNkmXc5s9fDVZLESaAA55NDzOxhy9GkcIdslK1eN7N6jIeHz" crossorigin="anonymous"></script>
<footer></footer>
5 changes: 4 additions & 1 deletion datasets.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<div class="list-group js-hidden">
{% for organization in site.organizations %}
{% assign count = site.datasets | where: "organization", organization.title | size %}
<a href="{{ site.baseurl}}{{ organization.url }}" class="list-group-item list-group-item-action d-flex justify-content-between align-items-center">
<a href="{{ site.baseurl }}{{ organization.url }}" class="list-group-item list-group-item-action d-flex justify-content-between align-items-center">
{{ organization.title }}
<span class="badge bg-primary rounded-pill">{{ count }}</span>
</a>
Expand All @@ -46,3 +46,6 @@
</div>
</div>
</div>

<!-- Load the javascript for search and category/org filtering -->
<script src="{{ site.baseurl }}/scripts/datasets.js"></script>
Loading
Loading