Does this actually work to drop javascript?#725
Draft
BryanQuigley wants to merge 2 commits into
Draft
Conversation
BryanQuigley
force-pushed
the
drop_jquery_lodash
branch
from
May 18, 2026 07:09
2138c0c to
e6cda18
Compare
rcheetham
reviewed
May 18, 2026
rcheetham
left a comment
rcheetham
left a comment
Member
There was a problem hiding this comment.
I tested in Docker and did not note any Javascript issues.
BryanQuigley
force-pushed
the
drop_jquery_lodash
branch
from
May 18, 2026 23:28
9883b10 to
c843a67
Compare
Collaborator
|
@BryanQuigley would you mind if i took a stab at refactoring this with alpinejs before upstreaming? it makes reactivity nice and clean. i can open up a pr against this one next week when i'm caught up on client work. |
Member
Author
|
@lydiascarf absolutely - I kinda switched to just factoring out boostrap first- but have ran out of time to push further- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR for testing.. Cause if I didn't actually miss anything this likely means we can drop using any JS parcel bundling..
Definitely want to upstream this first.
This is totally written by AI.