Fix bdev max rw size calculation #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsharma-dc
requested review from
Abhinandan-Purkait,
abhilashshetty04,
avishnu and
tiagolobocastro
tiagolobocastro
approved these changes
Mar 5, 2025
max write size calculation need to account aligned length and the blocklen with metadata as done via bdev_get_max_write. This otherwise fails during bdev_io_get_buf for bounce buffer where max length returned by bdev_io_get_max_buf_len breaches the iobuf_large length. Change-Id: I0e2ee2cfa80f0617f8b1379315b9dba2459d2c71 Signed-off-by: Diwakar Sharma <[email protected]>
dsharma-dc
force-pushed
the
bdev-max-rw-size
branch
from
bc1448a to
9535546
Compare
abhilashshetty04
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max write size calculation need to account aligned length and the blocklen with metadata as done via bdev_get_max_write. This otherwise fails during bdev_io_get_buf for bounce buffer where max length returned by bdev_io_get_max_buf_len breaches the iobuf_large length.
Change-Id: I0e2ee2cfa80f0617f8b1379315b9dba2459d2c71
Note
The corresponding fix on upstream SPDK is approved here: https://review.spdk.io/c/spdk/spdk/+/25665
The merge there might take time and hence cherry-picked locally from that branch already.