Skip to content

Fix bdev max rw size calculation #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsharma-dc merged 1 commit into from
Mar 5, 2025
Merged

Fix bdev max rw size calculation #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/bdev/bdev.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7795,17 +7795,17 @@ bdev_register(struct spdk_bdev *bdev)
}
}

spdk_iobuf_get_opts(&iobuf_opts, sizeof(iobuf_opts));
if (spdk_bdev_get_buf_align(bdev) > 1) {
bdev->max_rw_size = spdk_min(bdev->max_rw_size ? bdev->max_rw_size : UINT32_MAX,
iobuf_opts.large_bufsize / bdev->blocklen);
}

/* If the user didn't specify a write unit size, set it to one. */
if (bdev->write_unit_size == 0) {
bdev->write_unit_size = 1;
}

spdk_iobuf_get_opts(&iobuf_opts, sizeof(iobuf_opts));
if (spdk_bdev_get_buf_align(bdev) > 1) {
bdev->max_rw_size = spdk_min(bdev->max_rw_size ? bdev->max_rw_size : UINT32_MAX,
bdev_get_max_write(bdev, iobuf_opts.large_bufsize));
}

/* Set ACWU value to the write unit size if bdev module did not set it (does not support it natively) */
if (bdev->acwu == 0) {
bdev->acwu = bdev->write_unit_size;
Expand Down
Loading