Skip to content

lib/nvmf: Add vendor specific subsystem pause/resume#76

Merged
tiagolobocastro merged 6 commits into
openebs:v25.05.x-mayastorfrom
susobhandey:subsys_pause_timeout
Jun 3, 2026
Merged

lib/nvmf: Add vendor specific subsystem pause/resume#76
tiagolobocastro merged 6 commits into
openebs:v25.05.x-mayastorfrom
susobhandey:subsys_pause_timeout

Conversation

@susobhandey

Copy link
Copy Markdown

if vendor sets flag during subsystem pause
we keep allowing keep alive for 120 sec even though subsystem is not active
There is no change in fabric command. Only we allow admin cmds for 120 sec

120 sec is also configurable through RPC

Signed-off-by: Susobhan Dey <susobhan.dey@gmail.com>

@tiagolobocastro tiagolobocastro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change commit to something more like:
lib/nvmf: add vendor...

Comment thread lib/nvmf/subsystem.c Outdated
Comment thread lib/nvmf/nvmf_internal.h
Comment thread lib/nvmf/ctrlr.c Outdated
@susobhandey susobhandey changed the title Added vendor specific subsystem pause/resume lib/nvmf: Add vendor specific subsystem pause/resume May 13, 2026
@tiagolobocastro

Copy link
Copy Markdown
Member

@susobhandey please sign the commits for the DCO

Address the review comment from Tiago to remove the race window of poller being unregistred

Signed-off-by: Susobhan Dey <susobhan.dey@gmail.com>
@susobhandey susobhandey force-pushed the subsys_pause_timeout branch from 147fc02 to f7ed088 Compare May 15, 2026 04:25

@tiagolobocastro tiagolobocastro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look, tests are failing in the lint

Comment thread include/spdk/nvmf.h
Comment thread lib/nvmf/subsystem.c Outdated
Signed-off-by: Susobhan Dey <susobhan.dey@gmail.com>
@susobhandey susobhandey force-pushed the subsys_pause_timeout branch from 3ac5f9e to a88a5a4 Compare May 18, 2026 05:47
Signed-off-by: Susobhan Dey <susobhan.dey@gmail.com>
Also added rpc method to pause & resume subsystem using rpc.

Signed-off-by: Susobhan Dey <susobhan.dey@gmail.com>
@tiagolobocastro

Copy link
Copy Markdown
Member

@susobhandey ptal at CI failure

Signed-off-by: Susobhan Dey <susobhan.dey@gmail.com>
@tiagolobocastro tiagolobocastro merged commit 14acc38 into openebs:v25.05.x-mayastor Jun 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants