-
Notifications
You must be signed in to change notification settings - Fork 4.2k
refactor: changed create_user with UserFactory to avoid errors #28525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @mariajgrimaldi! I've created OSPR-5984 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
fda13cf to
4fa1cd1
Compare
openedx/core/djangoapps/content/learning_sequences/api/tests/test_outlines.py
Outdated
Show resolved
Hide resolved
fc4350b to
348031c
Compare
…tent profile errors
348031c to
2ee52ea
Compare
|
Your PR has finished running tests. There were no failures. |
|
Hey @felipemontoya, I hope you're doing great! As a core committer, what do you think about these improvements? Any feedback is welcome. |
felipemontoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Overall it improves the test quality, removes some warnings left from the lint amnesty and it will fix the errors we have on the events PR.
|
Since this PR is maintenance only, I believe it is ok to merge it with only one CC approval. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
@mariajgrimaldi @felipemontoya Thank you both! |
|
@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR replaces
User.objects.create_userreferences withUserProfile.create, to automatically create the user's profile avoiding tests errors.Supporting information
This was discussed -here- after we encountered some errors while using the user's profile in some tests. For example here:
https://build.testeng.edx.org/job/edx-platform-python-pipeline-pr/33620/#showFailuresLink
More in detail:
https://build.testeng.edx.org/job/edx-platform-python-pipeline-pr/33620/testReport/junit/lms.djangoapps.course_goals.tests.test_goals/TestCourseGoalsAPI/Run_Tests___lms_unit___test_add_goal/
Testing instructions
Run edxapp tests:
pytest lms/djangoapps/course_goals/tests/test_goals.py::TestCourseGoalsAPI::test_add_goalpaver test_js_run -s <lms|cms>Deadline
"None"
Other information
This PR just improves tests by adding missing data.