Repository navigation
tools(rdna): drop the TunableOp mirror and unused probes - #101
Merged
Merged
Conversation
This was referenced Oct 16, 2026
Point the V620 launchers and the coverage test at tools/rdna2_028/tunableop_env.sh, delete the byte-identical tools/rdna2 mirror, and remove configure_mtp_tunableop (no callers). Delete probes with no inbound reference. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Signed-off-by: BlivionIaG <15323295+BlivionIaG@users.noreply.github.com>
Retarget the V620 launchers, the live-prefill recipe, and the coverage test at tools/rdna2_028/tunableop_env.sh, and drop the unused configure_mtp_tunableop alias. configure_v620_tunableop stays. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Signed-off-by: BlivionIaG <15323295+BlivionIaG@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/tunableop-probe-cleanup-3a9a
branch
from
October 16, 2026 15:26
2199ddf to
600d446
Compare
BlivionIaG
marked this pull request as ready for review
October 16, 2026 15:26
BlivionIaG
added a commit
that referenced
this pull request
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Subtraction-only cleanup. The
tools/rdna2/tunableop_env.shmirror matchedtools/rdna2_028/tunableop_env.shbelow its header, so the V620 launchers, the live-prefill recipe, and the coverage test now source the remaining helper, and the mirror is deleted.configure_v620_tunableopis still defined there.configure_mtp_tunableophad no callers and is gone.Deleted probes with no inbound reference:
tools/probe_concurrent_greedy.py,tools/rdna2/tunableop_rows_probe.py,tools/rdna2/test_startup_plan_cpu.py(and its command indocs/rdna2/V620-CANDIDATE.md),tools/rdna/port_v031/gptq_moe_expert_check.py.Does not edit files owned by #100, #99, #44, or the #87 campaign deletions.
tools/rdna2_028/tunableop_env.shand the row-pipeline scripts stay.tools/rdna2/serve_v620_baseline.shis also in #25; the only edit here is the source path on the TunableOp line. #25's all-reduce defaults and native check are untouched.Not a duplicate: open PRs do not retarget this mirror or delete these probes (#87 keeps
tunableop_env.shand the row pipeline; #44 removes in-tree debug helpers, not these tools).Two README lines still name the deleted mirror (
tunableop/README.md,tunableop/rocm10-rocblas5.6/README.md). Those files are in #99 and were left alone.AI assistance was used. No model-output change, so no model eval.
Test Plan
Test Result
rgforconfigure_mtp_tunableop,probe_concurrent_greedy,tunableop_rows_probe,test_startup_plan_cpu, andgptq_moe_expert_check: no matches.rgfortools/rdna2/tunableop_env.sh:bash -non the four scripts: exit 0.tests.tools.test_v620_tuning_coverage: 4 passed in 0.238s (stdlib venv, no pip).