Repository navigation
cleanup(tools): drop finished-experiment drivers and unread env exports - #42
Closed
BlivionIaG wants to merge 3 commits into
Closed
BlivionIaG wants to merge 3 commits into
BlivionIaG wants to merge 3 commits into
Conversation
Delete unreferenced TunableOp step-3, PR #30, and split-K audit drivers, plus one-shot probes nothing else calls. Collapse the rdna2 TunableOp helper onto the rdna2_028 copy and remove the unused MTP alias. Stop exporting three env names nothing in vllm/ or csrc/ reads. Co-authored-by: Grok 4.7 <grok@x.ai> Signed-off-by: Blivion <kev29lt@gmail.com>
3 of 4 tasks
The CPU repro block in V620-CANDIDATE.md still invoked tools/rdna2/test_startup_plan_cpu.py, which this cleanup removed. Co-authored-by: Grok 4.7 <grok@x.ai> Signed-off-by: Blivion <kev29lt@gmail.com>
This was referenced Oct 7, 2026
Skip the 8s and 3s waits when pgrep finds no matching pid. TERM then KILL is unchanged when a pid with this VLLM_CACHE_ROOT is actually signaled. Co-authored-by: Grok 4.7 <grok@x.ai> Signed-off-by: Blivion <kev29lt@gmail.com>
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remove finished-experiment drivers under
tools/and three env exports that nothing invllm/orcsrc/reads. Livescripts/serve_rdna.shandscripts/rdna_launcher_common.shkeep the same serve behavior aside from those unread exports and one stale-process wait.Not a duplicate: open PRs #25, #2, #33, #37, #40, and #41 do not touch these files. Closed drafts #43 and #46 overlapped this change; this PR (#42) is the one to keep.
csrc/,vllm/, W4A8 kernels, andtools/rdna2/serve_v620_baseline.share untouched.AI assistance was used (Cursor Grok 4.7). No model-output, accuracy, or serving change, so no model eval.
Deleted (rg of each basename is empty outside historical docs /
bench_results/)campaign_3a_capture.sh,campaign_3bcd_arm.sh,campaign_3bcd_curate.sh,campaign_3d_freeze.shpr30_b1_probe.sh,pr30_b2_rocprof.sh,pr30_b3_driver.shaudit_w4a16.sh,audit_split/audit_split_swap.py,probe_prefill_split.py,probe_force_split.py,probe_gptq_k.pyparse_kernel_sass.py,probe_model_inspect2.py,probe_inmodel_layer.py,tools/probe_concurrent_greedy.py,tools/rdna2/tunableop_rows_probe.py,flashnext_w4a8_matrix.sh,tunableop_rows_e2e.sh,tools/rdna2/test_startup_plan_cpu.pyNo listed file was still called by a live path, so none were skipped.
Follow-up: the repro line
.venv/bin/python tools/rdna2/test_startup_plan_cpu.pyis removed fromdocs/rdna2/V620-CANDIDATE.md. The rest of that doc is unchanged.rg test_startup_plan_cpuis now empty.tools/rdna2_028/audit_split/is not empty after the.pydeletion.split_old.txtandsplit_fixed.txtwere not on the kill list (they were only inputs to the deletedaudit_w4a16.sh), so the directory stays.One stale mention left on purpose:
bench_results/2026-09-30_campaign-matrix/SUMMARY.mdstill namescampaign_3a_capture.sh.Trimmed
configure_mtp_tunableophad no callers. Removed once fromtools/rdna2_028/tunableop_env.sh.tools/rdna2/tunableop_env.shis now a thinsourceof that file.configure_tunableopandconfigure_v620_tunableopare unchanged.VLLM_RDNA_FORCE_FP16dropped fromscripts/rdna_launcher_common.shand the plan-key list inscripts/serve_rdna.sh.VLLM_ROCM_SKIP_LIVE_TAIL_HASHdropped fromscripts/recipes/full.envand the plan-key list inscripts/serve_rdna.sh.VLLM_ROCM_MOE_PREFILL=0dropped fromscripts/recipes/flashnext-mtp0.envandflashnext-mtp2.env. The name stays in theserve_rdna.shplan-key list because other launchers still export it (serve_v620_*.sh,step0_*.sh); those files were out of scope.rdna_kill_stalewaitsrdna_kill_stalestill sends TERM, then KILL, only to pids whoseVLLM_CACHE_ROOTmatches. The 8s sleep runs only after a TERM actually landed, and the 3s sleep runs only if any pid was signaled. A launch wherepgrepfinds nobody no longer waits 11s. The function still returns success in that case (serve_rdna.shisset -e).Test Plan
No GPU. Proof is reference search plus shell parse, and a source of the TunableOp helper through the thin mirror:
Also source
tools/rdna2/tunableop_env.shand callconfigure_v620_tunableopon an unknown library (same contract astests/tools/test_v620_tuning_coverage.py::test_unknown_library_disables_tuning_without_stopping_service).rdna_kill_stalewas checked underset -euo pipefailwithsleepandkilllogged: no matching pid does not sleep; a pid with a differentVLLM_CACHE_ROOTis left alone; a matching pid getskill -TERM,sleep 8,kill -KILL,sleep 3.Test Result
configure_mtp_tunableopsearch: onlybench_results/2026-09-30_campaign-matrix/SUMMARY.md(campaign_3a_capture.sh).test_startup_plan_cpuis gone from the tree, includingdocs/rdna2/V620-CANDIDATE.md.vllm/andcsrc/search for the three env names: empty.bash -non the edited shell files: all ok.configure_tunableopandconfigure_v620_tunableop, and does not defineconfigure_mtp_tunableop.0:unset, stderr containsWARNING.rdna_kill_stale: empty and cache-root mismatch skip both sleeps; a matching pid is signaled TERM then KILL with the 8s and 3s waits.Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing