Repository navigation
cleanup(scripts): drop unread serve knobs and idle kill sleep - #46
Closed
BlivionIaG wants to merge 1 commit into
Closed
BlivionIaG wants to merge 1 commit into
BlivionIaG wants to merge 1 commit into
Conversation
Stop exporting three env names nothing in vllm/, csrc/, or tests/ reads. Point tools/rdna2/tunableop_env.sh at the rdna2_028 copy and delete the unused configure_mtp_tunableop alias. rdna_kill_stale sleeps only after it actually signals a pid. Co-authored-by: Grok 4.7 <grok@x.ai> Signed-off-by: BlivionIaG <kev29lt@gmail.com>
Author
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Live serve path only. Four items, no new flags, functions, or files.
vllm/,csrc/, ortests/reads.rg -n NAME vllm csrc testsis empty for each name below, so none of the findings were dropped.VLLM_RDNA_FORCE_FP16: removed fromrdna_initand fromserve_rdna.sh's print list.VLLM_ROCM_SKIP_LIVE_TAIL_HASH: removed fromscripts/recipes/full.env(assignment and the stale comment) and from the print list.VLLM_ROCM_MOE_PREFILL: removed fromflashnext-mtp0.env,flashnext-mtp2.env, and the print list.VLLM_GDN_HIP_PREFILLstays; it is read invllm/model_executor/layers/mamba/gdn/qwen_gdn_linear_attn.py.tools/rdna2/tunableop_env.shwas byte-identical totools/rdna2_028/tunableop_env.shbelow a 3-line header. Its body is now onesourceof therdna2_028file, path resolved from this script's directory. SPDX header kept. Callers (serve_v620_baseline.shincluded; that file is not edited) still getconfigure_tunableop,configure_v620_tunableop, and_tunableop_profiles.configure_mtp_tunableopand its "kept for existing callers" comment.rgof the name is empty after the edit.rdna_kill_staleslept 8s after TERM and 3s after the loop even whenpgrepmatched nothing. It now sleeps only after a pid was actually signaled. The pgrep/kill loops are unchanged.Not a duplicate of #42. That PR deletes finished-experiment drivers under
tools/and leavesVLLM_ROCM_MOE_PREFILLin theserve_rdna.shprint list. It does not changerdna_kill_stale. This PR is only the live serve path (scripts/serve_rdna.sh,scripts/rdna_launcher_common.sh,scripts/recipes/*.env, the two TunableOp helpers). Untouched:tools/rdna2/serve_v620_baseline.sh(#25),docs/,bench_results/, everyvllm/andcsrc/file, and the othertools/scripts.AI assistance was used (Cursor Grok 4.7). No model-output, accuracy, or serving change, so no model eval. Launch behavior changes only by not exporting unread names and by skipping the 11s wait when there is nothing to kill.
Test Plan
rdna_kill_staleunderset -euo pipefail: time a call with no matching pid; then a pid whose command line matches but whoseVLLM_CACHE_ROOTdoes not; then a pid that matches both (sleep overridden so the positive path does not actually wait 11s).Test Result
rgof the three env names undervllm/,csrc/, andtests/: no matches.configure_mtp_tunableop: no matches.bash -non the seven touched shell files: ok.shellcheck 0.9.0 (same invocation,
.shellcheckrcapplied): 126 findings before, 123 after, 0 new. The three that disappeared areSC2034on the deleted recipe assignments.PRINT=1env diff, only these lines removed (commands unchanged):export VLLM_RDNA_FORCE_FP16='1'fullonly:export VLLM_ROCM_SKIP_LIVE_TAIL_HASH='1'flashnext-mtp0andflashnext-mtp2only:export VLLM_ROCM_MOE_PREFILL='0'VLLM_GDN_HIP_PREFILL='0'still printed for the two flashnext-mtp recipes.declare -Faftersource tools/rdna2/tunableop_env.sh:Before, the same list also had
configure_mtp_tunableop.declare -fbodies are identical to sourcingtools/rdna2_028/tunableop_env.shdirectly.rdna_kill_stale:set -edid not abort). Before this change the same call took 11015 ms.VLLM_CACHE_ROOT: no sleep, process left alive.VLLM_CACHE_ROOT:killsucceeded, recordedSLEEP 8thenSLEEP 3, process was gone, function returned 0.python -m pytest tests/tools/test_v620_tuning_coverage.py -qcannot loadtests/conftest.pyhere (it imports torch and vllm; no project venv). The same file with--noconfteston CPU:4 passed, 2 subtests passed in 0.20s.python3 -m unittest tests.tools.test_v620_tuning_coverage -q:Ran 4 tests ... OK. That test sourcestools/rdna2/tunableop_env.shand callsconfigure_v620_tunableop.Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing