Skip to content

Conversation

@pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented May 21, 2025

Changes

  1. Use RDS Proxy
  2. Read postman queue rate limit from env var
  3. Hide empty row ID tooltip in update row action

To check

Env vars are set:

  • plumber-prod-rds-proxy-host
  • plumber-prod-postman-rate-limit

pregnantboy and others added 4 commits May 21, 2025 14:14
## Changes
- use rds proxy host if exists. else, fallback to rds cluster host
- move postman-sms qps rate limit to env var instead of hardcoding


## To test
- Check that postman sms qps env var is set
  - [x] Prod
  - [x] Staging
  - [x] UAT
- [x] Check that RDS Proxy on Prod is accessible before merging

---------

Co-authored-by: kevinkim-ogp <[email protected]>
Set queue rate limit for postman email actions based on env var

## TODO:
Verify that the postman rate limit env var is set 
- [x] Prod
- [x] Staging
- [x] UAT
## Problem
Tooltip for empty Row ID is misleading as the intent of showing the
empty Row ID is for users to still configure their update row step with
the empty variable.


![image](https://github.com/user-attachments/assets/400adba9-83ef-43b4-b2da-2d6d0a01003e)


## Solution
Hide the tooltip specifically for empty Row ID variable:
* Checks both attribute id and label to ensure that it is a Tiles Row ID
variable

<img width="862" alt="Screenshot 2025-05-15 at 3 54 25 PM"
src="https://github.com/user-attachments/assets/e118ea59-bcc2-4661-93c3-30801f3a19fa"
/>
@pregnantboy pregnantboy requested a review from a team as a code owner May 21, 2025 06:51
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks sir 👍

@datadog-opengovsg
Copy link

Datadog Report

Branch report: develop-v2
Commit report: bfd6625
Test service: plumber

✅ 0 Failed, 772 Passed, 0 Skipped, 2m 24.94s Total Time
➡️ Test Sessions change in coverage: 1 no change

@pregnantboy pregnantboy merged commit b173fa6 into production May 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants