-
Notifications
You must be signed in to change notification settings - Fork 8
PLU-489 [FIND-MULTIPLE-ROWS-7]: Compute parameters with wildcard #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLU-489 [FIND-MULTIPLE-ROWS-7]: Compute parameters with wildcard #1029
Conversation
21f1a5b to
6055f13
Compare
Datadog ReportBranch report: ✅ 0 Failed, 852 Passed, 0 Skipped, 2m 39.78s Total Time |
6055f13 to
b48072a
Compare
8f7f54b to
f4ad618
Compare
|
BugBot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ BugBot reviewed your changes and found no bugs!
BugBot free trial expires on June 9, 2025
You have used $0.00 of your $1.00 spend limit so far. Manage your spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
|
||
| const variableRegExp = | ||
| /({{step\.[\da-f]{8}-(?:[\da-f]{4}-){3}[\da-f]{12}(?:\.[\da-zA-Z-_ ]+)+}})/g | ||
| /({{step\.[\da-f]{8}-(?:[\da-f]{4}-){3}[\da-f]{12}(?:\.[\w* -]+)+}})/g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be slightly stricter to enforce that asterisk (*) must be the only character in the segment
valid: {{step.00000000-0000-0000-0000-000000000000.*.abc}}
invalid: {{step.00000000-0000-0000-0000-000000000000.def*.abc}}
| /({{step\.[\da-f]{8}-(?:[\da-f]{4}-){3}[\da-f]{12}(?:\.[\w* -]+)+}})/g | |
| /({{step\.[\da-f]{8}-(?:[\da-f]{4}-){3}[\da-f]{12}(?:\.([\w -]+|\*))+}})/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not enforce that asterisk cannot be in the last segment. for that the check can be done later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated regex and added helper func to validate the step variable.
we only allow 1 wildcard and it cannot be at the start or end of the variable segment, example
invalid: {{step.00000000-0000-0000-0000-000000000000.*.abc}}
invalid: {{step.00000000-0000-0000-0000-000000000000.abc.*}}
invalid: {{step.00000000-0000-0000-0000-000000000000.abc*.def.*.ghi}}
valid: {{step.00000000-0000-0000-0000-000000000000.abc.*.def}}
| return { | ||
| before: arr.slice(0, wildcardIndex).join('.'), | ||
| after: arr.slice(wildcardIndex + 1).join('.'), | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there edge cases to be handled here?
| ? base | ||
| : [base] | ||
|
|
||
| return values.join(`${GET_ALL_SEPARATOR} `) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this break if values contain comma?
b48072a to
92144a9
Compare
6a0f107 to
6914a25
Compare
92144a9 to
3e38748
Compare
|
closing this PR first, we are not allowing users to select the column variable in the find multiple rows output. |

TL;DR
This PR adds support for wildcard syntax in parameter computation, allowing users to use column values from find multiple rows / get table rows steps in subsequent steps.
What changed?
{{step.id.arrayProp.*}}{{step.id.arrayOfObjects.*.propertyName}}The implementation includes:
compute-parameters.tsThis enhancement provides more flexibility when working with array data in workflow steps.
How to test?
Setup
Test
Screenshots
Screen Recording 2025-06-02 at 6.25.58 PM.mov (uploaded via Graphite)