Skip to content

Conversation

@m0nggh
Copy link
Contributor

@m0nggh m0nggh commented May 6, 2025

Fixes

  • Remove deleted column keys when updating row
  • Dedupe multiple CC repeated emails

m0nggh and others added 4 commits May 6, 2025 16:39
## Problem

User wanted to send emails with the CC functionality but her emails were
of different case and it was giving an error because we don't dedupe it
properly.

## Solution

Lowercase the emails since they are no case-sensitive

## Tests
- [x] Multiple repeated cc emails of different casing are deduped and
does not throw an error
- [x] Multiple repeated destination emails of different casing are also
deduped now so it won't be sent more than once to the same user email
## Problem
After deleting a column, users cannot update rows as it tries to store a
row with non-existent column keys

## Solution
Remove deleted column keys from data before writing.

Also specify cache merge strategy for TableMetadata.columns
@m0nggh m0nggh requested a review from a team as a code owner May 6, 2025 08:59
@datadog-opengovsg
Copy link

Datadog Report

Branch report: develop-v2
Commit report: 373c08e
Test service: plumber

✅ 0 Failed, 773 Passed, 0 Skipped, 2m 40.81s Total Time
➡️ Test Sessions change in coverage: 1 no change

Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@m0nggh m0nggh merged commit 2859cfd into production May 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants