Skip to content

[TILES-V2-2]: add new column to table_metadata #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented May 6, 2025

Changes

Added a new db column to the table_metadata table to distinguish between PostgreSQL and DynamoDB tables.

What changed?

  • Created a new migration file 20250506071427_add_table_metadata_db_column.ts that adds a db column to the table_metadata table with a default value of 'ddb' and not nullable constraint
  • Updated the TableMetadata model to include the new db property with type 'pg' | 'ddb'

How to test?

  1. Run the migration
  2. Verify the column exists in the database schema
  3. Check that existing records have the default 'ddb' value

@datadog-opengovsg
Copy link

Datadog Report

Branch report: tiles-v2/table-metadata-db
Commit report: 1dacf89
Test service: plumber

✅ 0 Failed, 772 Passed, 0 Skipped, 2m 26s Total Time
➡️ Test Sessions change in coverage: 1 no change

Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested and confirmed db column is created and defaults to ddb during migration

Copy link
Contributor Author

pregnantboy commented Jun 5, 2025

Merge activity

  • Jun 5, 7:16 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 5, 7:17 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 5, 7:19 AM UTC: @pregnantboy merged this pull request with Graphite.

@pregnantboy pregnantboy changed the base branch from tiles-v2/pg-docker to graphite-base/973 June 5, 2025 07:16
@pregnantboy pregnantboy changed the base branch from graphite-base/973 to tiles-v2/trunk June 5, 2025 07:16
@pregnantboy pregnantboy force-pushed the tiles-v2/table-metadata-db branch from 1dacf89 to 935c534 Compare June 5, 2025 07:17
Copy link

@cursor-com cursor-com bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!


BugBot free trial expires on June 9, 2025
You have used $0.00 of your $1.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

@pregnantboy pregnantboy merged commit 89e5ec6 into tiles-v2/trunk Jun 5, 2025
2 checks passed
@pregnantboy pregnantboy deleted the tiles-v2/table-metadata-db branch June 5, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants