Skip to content

[TILES-V2-4]: reorganise files and update import paths #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented May 6, 2025

Changes

Reorganized table row models by moving them from /models/dynamodb/table-row to /models/tiles/dynamodb/table-row and separated types into a dedicated file.

What changed?

  • Moved table row models and functions from /models/dynamodb/table-row to /models/tiles/dynamodb/table-row
  • Extracted types from /models/dynamodb/table-row/types.ts to /models/tiles/types.ts
  • Updated all imports across the codebase to reference the new file locations
  • Moved helper functions from /models/dynamodb/helpers.ts to /models/tiles/dynamodb/helpers.ts
  • Updated all test files to use the new import paths

How to test?

  1. Run the existing test suite to ensure all functionality works as expected
  2. Verify that all table operations (create, read, update, delete) still function correctly
  3. Check that the integration tests pass with the new import paths

@pregnantboy pregnantboy changed the title chore: reorganise files and update import paths [TILES-V2-4]: reorganise files and update import paths May 6, 2025
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented May 6, 2025

Datadog Report

Branch report: tiles-v2/reorganise-files
Commit report: 82e857d
Test service: plumber

✅ 0 Failed, 772 Passed, 0 Skipped, 2m 27.89s Total Time
🔻 Test Sessions change in coverage: 1 decreased (-0.15%)

🔻 Code Coverage Decreases vs Default Branch (1)

Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested that all existing tiles functions and tests work

Copy link
Contributor Author

pregnantboy commented Jun 5, 2025

Merge activity

  • Jun 5, 7:16 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 5, 7:23 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 5, 7:25 AM UTC: @pregnantboy merged this pull request with Graphite.

@pregnantboy pregnantboy changed the base branch from tiles-v2/pg-functions to graphite-base/975 June 5, 2025 07:20
@pregnantboy pregnantboy changed the base branch from graphite-base/975 to tiles-v2/trunk June 5, 2025 07:22
@pregnantboy pregnantboy force-pushed the tiles-v2/reorganise-files branch from 82e857d to 1153162 Compare June 5, 2025 07:23
Copy link

@cursor-com cursor-com bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!


BugBot free trial expires on June 9, 2025
You have used $0.00 of your $1.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

@pregnantboy pregnantboy merged commit c58f16b into tiles-v2/trunk Jun 5, 2025
2 checks passed
@pregnantboy pregnantboy deleted the tiles-v2/reorganise-files branch June 5, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants