Skip to content

Conversation

@PrawiraGenestonlia
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the npm publishing workflow by migrating from token-based authentication to OIDC (OpenID Connect) authentication and adding automated git tagging functionality.

  • Updates GitHub Actions to v4 (checkout and setup-node)
  • Migrates from NPM_TOKEN secret to OIDC-based authentication with id-token permissions
  • Adds automated git tag creation and pushing based on package.json version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 40 to 41
- run: |
git tag "v$(jq -r .version package.json)"
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tagging logic creates tags based on the package.json version, but this happens after npm ci and before npm publish. If the version in package.json hasn't been bumped before the workflow runs, this will attempt to create a tag for a version that may already exist or doesn't represent new changes. Consider adding version bumping logic (e.g., npm version) before creating the tag, or ensure the version is updated as part of the release process before triggering this workflow.

Suggested change
- run: |
git tag "v$(jq -r .version package.json)"
- name: Bump version and create tag
run: |
npm version patch -m "chore(release): %s [skip ci]"
git push origin HEAD

Copilot uses AI. Check for mistakes.
@PrawiraGenestonlia PrawiraGenestonlia merged commit f498c73 into develop Nov 10, 2025
4 of 6 checks passed
@PrawiraGenestonlia PrawiraGenestonlia deleted the chore/npm-oidc branch November 10, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant