-
Notifications
You must be signed in to change notification settings - Fork 10
feat(kysely): add kysely to starter-kit #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
karrui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add examples for the proper usage of the new generators so ppl can see how they can be used? if necessary, can add short README docs (that we can then port into starter kit docs later)
|
zod-generator not a good citizen with its obfuscated code hehe |
83b07cd to
4feefa1
Compare
this is because we're going to re-use this for app
4feefa1 to
6dcc9da
Compare
- avoid having to run `docker-compose up` manually - maybe should chnage to deps?
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
karrui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. feel free to merge if you think my comments don't require changes
| We are not supposed to use `db.$kysely.transaction()` directly as it is not supported by the extension. Instead, use Prisma transactions as shown above. | ||
| ``` | ||
|
|
||
| ### Raw SQL Queries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should highlight that this is where kysely shines. instead of using raw sql queries, should just use kysely query builder
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|

Summary
minimalset up so it generates crud and abit more on topChanges
New Dependencies
kysely- Type-safe SQL query builderprisma-extension-kysely- Prisma extension for Kysely integrationprisma-kysely- Generator for Kysely types from Prisma schemaprisma-zod-generator- Generator for Zod schemas from Prisma schemaConfiguration
src/generated/prisma,src/generated/kysely, andsrc/generated/zodprisma-extension-kyselyandprisma-kyselyto pnpm catalogTest plan
pnpm prisma generateto verify all generators work correctlypackages/db/src/generated/kyselypackages/db/src/generated/zod