-
Notifications
You must be signed in to change notification settings - Fork 10
chore: upgrade to prisma 7 #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
karrui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| diff --git a/dist/cjs/index.js b/dist/cjs/index.js | ||
| index ab08b5d36b43ea10a2b3c5e480b2e9af2c12929c..412e6c0ca3154299b7e41ab9c847f9164d1bfe4e 100644 | ||
| --- a/dist/cjs/index.js | ||
| +++ b/dist/cjs/index.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we technically don't support cjs but ok
karrui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Merge activity
|
the `url` param is no longer supported (https://www.prisma.io/docs/orm/more/upgrade-guides/upgrading-versions/upgrading-to-prisma-7#prisma-config-is-now-used-to-configure-the-prisma-cli) so have to swap it to the config instead.
- we needed this patch because they were importing `Prisma` from `@prisma/client`, which got removed in v7 - patched to `@prisma/client/extension` which is the correct path. thanks homie on gh https://github.com/eoin-obrien/prisma-extension-kysely/pull/208/files
since we pass all the checks, if we can't delete the token, we just throw a trpc error to feedabck to the user
966ffc2 to
57fc0b8
Compare

Changes
the
urlparam is no longer supported(https://www.prisma.io/docs/orm/more/upgrade-guides/upgrading-versions/upgrading-to-prisma-7#prisma-config-is-now-used-to-configure-the-prisma-cli) so have to swap it to the config instead. take note that you might have to update your
prisma-lsversion so that the typings are correctpatch
prisma-extension-kysely; we needed this patch because they were importingPrismafrom@prisma/client, which got removed in v7. this was patched to@prisma/client/extensionwhich is the correct path.Tests
packages/dbto verify that they were working.