Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a PMA (Physical Memory Attributes) configuration file for the rv64gc RISC-V configuration. The file defines memory regions and their access characteristics according to the RISC-V Privileged Architecture specification, including regions for BOOTROM, peripherals (SDC, CLINT, PLIC, UART0, GPIO, SPI), main RAM (UNCORE_RAM), and a catch-all undefined memory region.
Changes:
- Added comprehensive PMA definitions for 9 memory regions with detailed attribute specifications
- Documented all required and optional PMA attributes in the file header
- Configured memory access properties including cacheability, coherency, ordering, atomic operations, and alignment support
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
config/rv64gc/pma.yaml
Outdated
| read: true | ||
| write: true | ||
| execute: false | ||
| cachable: false |
There was a problem hiding this comment.
The attribute name should be "cacheable" (not "cachable") to match the documentation on line 15 and maintain consistency with the correct spelling.
config/rv64gc/pma.yaml
Outdated
| misaligned_atomicity_granule: 64 | ||
| - name: "Undefined memory inaccessible" | ||
| lo: "0x0000000000" | ||
| hi: "0xFFFFFFFFFFFFFFFFFF" |
There was a problem hiding this comment.
The hexadecimal value has 18 hex digits, which exceeds the maximum for a 64-bit address (16 hex digits). For rv64gc (64-bit RISC-V), the maximum address should be "0xFFFFFFFFFFFFFFFF" (16 F's, not 18).
| hi: "0xFFFFFFFFFFFFFFFFFF" | |
| hi: "0xFFFFFFFFFFFFFFFF" |
config/rv64gc/pma.yaml
Outdated
| read: true | ||
| write: true | ||
| execute: false | ||
| cachable: false |
There was a problem hiding this comment.
The attribute name should be "cacheable" (not "cachable") to match the documentation on line 15 and maintain consistency with the correct spelling.
config/rv64gc/pma.yaml
Outdated
| read: true | ||
| write: true | ||
| execute: false | ||
| cachable: false |
There was a problem hiding this comment.
The attribute name should be "cacheable" (not "cachable") to match the documentation on line 15 and maintain consistency with the correct spelling.
config/rv64gc/pma.yaml
Outdated
| read: true | ||
| write: true | ||
| execute: false | ||
| cachable: false |
There was a problem hiding this comment.
The attribute name should be "cacheable" (not "cachable") to match the documentation on line 15 and maintain consistency with the correct spelling.
1 participant
No description provided.