Skip to content

Conversation

@artur-oracle
Copy link
Member

@artur-oracle artur-oracle commented Dec 24, 2025

12 bytes is the recommended size for GCM per NIST SP 800-38D:

For IVs, it is recommended that implementations restrict support to the length of 96 bits, to
promote interoperability, efficiency, and simplicity of design.`

Larger IV size requires an extra hashing step (GHASH). Currently we have it set to 16 bytes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374317: Change GCM IV size to 12 bytes when encrypting/decrypting TLS session ticket (Enhancement - P4)

Reviewers without OpenJDK IDs

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28971/head:pull/28971
$ git checkout pull/28971

Update a local copy of the PR:
$ git checkout pull/28971
$ git pull https://git.openjdk.org/jdk.git pull/28971/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28971

View PR using the GUI difftool:
$ git pr show -t 28971

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28971.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 24, 2025

👋 Welcome back abarashev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Dec 24, 2025

@artur-oracle The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 24, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 24, 2025

Webrevs

@ecki
Copy link
Contributor

ecki commented Dec 24, 2025

Hm, if there are no test changes needed. We might Need to add some. Should we dynamically accept 12-16 Byte IVs? Not sure why the mail talked about 96 Bits for Mac as well, but I think even NIST prefers 128 (in fact that’s a major weakness going forward that’s its limited to the blockiere)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review security [email protected]

Development

Successfully merging this pull request may close these issues.

3 participants