Skip to content

8374317: Change GCM IV size to 12 bytes when encrypting/decrypting TLS session ticket #28971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artur-oracle wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −3
Open

8374317: Change GCM IV size to 12 bytes when encrypting/decrypting TLS session ticket #28971

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7292169
8374317: Change GCM IV size to 12 bytes when encrypting/decrypting TL…
artur-oracle Dec 24, 2025
4f9fd14
Merge branch 'master' into JDK-8374317
artur-oracle Dec 24, 2025
31f7362
Make GCM IV a constant. Update copyright year.
artur-oracle Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/java.base/share/classes/sun/security/ssl/SessionTicketExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019, 2025, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2019, 2026, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -178,6 +178,7 @@ static StatelessKey getCurrentKey(HandshakeContext hc) {
*/
static final class SessionTicketSpec implements SSLExtensionSpec {
private static final int GCM_TAG_LEN = 128;
private static final int GCM_IV_LEN = 12;
ByteBuffer data;
static final ByteBuffer zero = ByteBuffer.wrap(new byte[0]);

Expand Down Expand Up @@ -215,7 +216,7 @@ byte[] encrypt(HandshakeContext hc, SSLSessionImpl session) {

try {
StatelessKey key = KeyState.getCurrentKey(hc);
byte[] iv = new byte[16];
byte[] iv = new byte[GCM_IV_LEN];

SecureRandom random = hc.sslContext.getSecureRandom();
random.nextBytes(iv);
Expand Down Expand Up @@ -269,7 +270,7 @@ ByteBuffer decrypt(HandshakeContext hc) {
return null;
}

iv = new byte[16];
iv = new byte[GCM_IV_LEN];
data.get(iv);
Cipher c = Cipher.getInstance("AES/GCM/NoPadding");
c.init(Cipher.DECRYPT_MODE, key.key,
Expand Down