8354489: Some callers of VMError::report_and_die think it can return

[Sorna-Sarathi]

VMError::report_and_die is [[noreturn]] and cannot return, even when UseOSErrorReporting is enabled.

Remove misleading comments and dead code from report_error(os_windows.cpp) and report_vm_out_of_memory (debug.cpp).

JBS Issue: JDK-8354489

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8354489: Some callers of VMError::report_and_die think it can return (Enhancement - P4)

Reviewers

• Amit Kumar (@offamitkumar - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32054/head:pull/32054
$ git checkout pull/32054

Update a local copy of the PR:
$ git checkout pull/32054
$ git pull https://git.openjdk.org/jdk.git pull/32054/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32054

View PR using the GUI difftool:
$ git pr show -t 32054

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32054.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssarathi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@Sorna-Sarathi The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 00: Full (cb8e5b21)

[offamitkumar]

LGTM.

[dholmes-ora]

Looks good but one further change requested. Thanks

[dholmes-ora]

Just an observation but this helper method has served no purpose since JDK-8080775 changed the VMError code back in JDK 9.

[dholmes-ora]

The va_end is also unreachable and should also be deleted.

I'm a little suprised the compiler doesn't complain about code after a noreturn method call.

[dholmes-ora]

Hmm actually this occurs in a number of places, so we should either change all or none. So I think leave this for a separate issue.

[Sorna-Sarathi]

Yeah, I've already thought about that. As you said, it occurs in other functions too. So, I didn't remove here for consistency.

[dholmes-ora]

There are other places that need fixing not mentioned in the JBS issue e.g. there are PosixSignals::pd_hotspot_signal_handler definitions which follow it with a ShouldNotReachHere().

[dholmes-ora]

I think this needs some discussion we have a lot of conservative use of ShouldNotReachHere() after the calls, which are semantically equivalent to the guarantee that has been flagged here. So either they all need to be removed or they all stay.