Skip to content

8354489: Some callers of VMError::report_and_die think it can return #32054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sorna-Sarathi wants to merge 2 commits into
base: master
Choose a base branch
from
+0 −12
Open

8354489: Some callers of VMError::report_and_die think it can return #32054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb8e5b2
8354489:Remove misleading comments
Sorna-Sarathi Jul 27, 2026
df847c8
Address review comments
Sorna-Sarathi Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/hotspot/os/windows/os_windows.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2671,14 +2671,6 @@ LONG Handle_IDiv_Exception(struct _EXCEPTION_POINTERS* exceptionInfo) {
return EXCEPTION_CONTINUE_EXECUTION;
}

static inline void report_error(Thread* t, DWORD exception_code,
address addr, void* siginfo, void* context) {
VMError::report_and_die(t, exception_code, addr, siginfo, context);

// If UseOSErrorReporting, this will return here and save the error file
// somewhere where we can find it in the minidump.
}

//-----------------------------------------------------------------------------
JNIEXPORT
LONG WINAPI topLevelExceptionFilter(struct _EXCEPTION_POINTERS* exceptionInfo) {
Expand Down
4 changes: 0 additions & 4 deletions src/hotspot/share/utilities/debug.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,10 +240,6 @@ void report_vm_out_of_memory(const char* file, int line, size_t size,

VMError::report_and_die(Thread::current_or_null(), file, line, size, vm_err_type, detail_fmt, detail_args);
va_end(detail_args);

@dholmes-ora dholmes-ora Jul 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The va_end is also unreachable and should also be deleted.

I'm a little suprised the compiler doesn't complain about code after a noreturn method call.

@dholmes-ora dholmes-ora Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm actually this occurs in a number of places, so we should either change all or none. So I think leave this for a separate issue.

@Sorna-Sarathi Sorna-Sarathi Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've already thought about that. As you said, it occurs in other functions too. So, I didn't remove here for consistency.

@iklam iklam Jul 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if va_end can be omitted. Could it lead to undefined behavior?


// The UseOSErrorReporting option in report_and_die() may allow a return
// to here. If so then we'll have to figure out how to handle it.
guarantee(false, "report_and_die() should not return here");
}

void report_should_not_call(const char* file, int line) {
Expand Down