Skip to content

8366261: Provide utility methods for sun.security.util.Password#2616

Open
GoeLin wants to merge 3 commits intoopenjdk:masterfrom
GoeLin:goetz_backport_8366261
Open

8366261: Provide utility methods for sun.security.util.Password#2616
GoeLin wants to merge 3 commits intoopenjdk:masterfrom
GoeLin:goetz_backport_8366261

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 18, 2026

src/java.base/share/classes/java/io/Console.java
Resolved several chunks

  • import
  • isTerminal() does not exist in 21, omitted.
  • two chunks need to be implemented differently: replace istty() by the two
    new methods.
  • place new methods in file

src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java
Resolved because https://bugs.openjdk.org/browse/JDK-8330276: "Console methods with explicit Locale" is not in 21.

src/java.base/unix/native/libjava/Console_md.c
src/java.base/windows/native/libjava/Console_md.c
test/jdk/java/io/Console/ModuleSelectionTest.java
Trivial resolves.

Further I needed adaptions to make it compile, see extra commit.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8366261 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366261: Provide utility methods for sun.security.util.Password (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2616/head:pull/2616
$ git checkout pull/2616

Update a local copy of the PR:
$ git checkout pull/2616
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2616/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2616

View PR using the GUI difftool:
$ git pr show -t 2616

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2616.diff

Using Webrev

Link to Webrev Comment

@GoeLin GoeLin changed the title Goetz backport 8366261 backport b0a520657d980f14b86afe6027dc0ebd34afef8f Feb 18, 2026
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 18, 2026

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 18, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport b0a520657d980f14b86afe6027dc0ebd34afef8f 8366261: Provide utility methods for sun.security.util.Password Feb 18, 2026
@openjdk
Copy link

openjdk bot commented Feb 18, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Feb 18, 2026
@GoeLin GoeLin marked this pull request as ready for review February 19, 2026 07:53
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 19, 2026
@mlbridge
Copy link

mlbridge bot commented Feb 19, 2026

Webrevs

Copy link
Contributor

@schmelter-sap schmelter-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Feb 19, 2026

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants

Comments