Setting the UID of old object to new object, while using some CD tools(like OCM,Karmada) to update workload#319
Conversation
|
Welcome @ivan-cai! It looks like this is your first PR to openkruise/rollouts 🎉 |
ivan-cai
force-pushed
the
update_by_cd_tool
branch
from
96bd6ca to
4525dcf
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #319 +/- ##
==========================================
+ Coverage 51.36% 51.38% +0.02%
==========================================
Files 66 66
Lines 8551 8559 +8
==========================================
+ Hits 4392 4398 +6
- Misses 3574 3575 +1
- Partials 585 586 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
…object, while using some CD tools(like OCM,Karmada) to update workload Signed-off-by: caijing <caijing.cai@alibaba-inc.com> move set logic into handle workload function Signed-off-by: caijing <caijing.cai@alibaba-inc.com>
ivan-cai
force-pushed
the
update_by_cd_tool
branch
from
7285f39 to
c1f3880
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…object, while using some CD tools(like OCM,Karmada) to update workload (#319) move set logic into handle workload function Signed-off-by: caijing <caijing.cai@alibaba-inc.com>
4 participants
Ⅰ. Describe what this PR does
If updating a deployment by some CD tools(like OCM,Karmada), the UID of new object often is empty. ReplicaSet will not match the deployment, and will
Cannot find any activate replicaset for deployment x/x, no need to rolling.rollouts/pkg/util/controller_finder.go
Line 500 in 5b48898
Ⅱ. Does this pull request fix one issue?
NONE