Skip to content

feat(subs): add BillingAnchor #2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

GAlexIHU
Copy link
Contributor

@GAlexIHU GAlexIHU commented Jun 2, 2025

Overview

Add custom billing anchor different from subscription start

TODO

  • assert phaseiterator & sync that they use correct values
  • add integration test for first of month billing usecase

@GAlexIHU GAlexIHU self-assigned this Jun 2, 2025
Copy link

coderabbitai bot commented Jun 2, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

ALTER TABLE "subscriptions" ADD COLUMN "billing_anchor" timestamptz;

-- update all entries to set the billing anchor to the active_from time
UPDATE "subscriptions" SET "billing_anchor" = "active_from" WHERE "billing_anchor" IS NULL;
Copy link
Contributor

@turip turip Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original spec was that we align the billing anchor to the phase's start to prevent pro-rating at the beginning of the phases if the alignment mode is set to phase.

I would recommend to add two fields:

  • The alignment kind which is phase or anchor (enum)
  • And an optional billing anchor if the alignment is set to anchor.

The major difference is that in phase mode the alignment is guaranteed to the phase's start so no prorating occurs at the beginning of the phase.

If the billing anchor is set to anchor, then each phase's first period will be pro-rated so that later items are aligned.

@GAlexIHU GAlexIHU force-pushed the feat/test-cadence-sync branch from 9de492a to a64b4b2 Compare June 3, 2025 12:14
@GAlexIHU GAlexIHU force-pushed the galexi/feat/subs-billing-anchor branch from 24f28a1 to a71ee81 Compare June 3, 2025 12:15
@GAlexIHU GAlexIHU force-pushed the feat/test-cadence-sync branch from a64b4b2 to 3b4cfe9 Compare June 3, 2025 14:27
@GAlexIHU GAlexIHU force-pushed the galexi/feat/subs-billing-anchor branch from a71ee81 to 9cf48de Compare June 3, 2025 14:28
Base automatically changed from feat/test-cadence-sync to feat/plan-billing-cadence-sync June 3, 2025 14:29
Base automatically changed from feat/plan-billing-cadence-sync to feat/plan-billing-cadence June 3, 2025 14:30
@GAlexIHU GAlexIHU force-pushed the galexi/feat/subs-billing-anchor branch from 9cf48de to c4b8ce8 Compare June 5, 2025 15:29
@GAlexIHU GAlexIHU force-pushed the feat/plan-billing-cadence branch from dd5b5ab to 8a0c51c Compare June 6, 2025 13:16
@GAlexIHU GAlexIHU force-pushed the feat/plan-billing-cadence branch from 8a0c51c to d8bcbb2 Compare June 10, 2025 10:42
Base automatically changed from feat/plan-billing-cadence to main June 10, 2025 14:16
@GAlexIHU GAlexIHU force-pushed the galexi/feat/subs-billing-anchor branch from c4b8ce8 to 17aaadc Compare June 10, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants