Conversation
rcannood
suggested changes
May 6, 2025
rcannood
left a comment
rcannood
left a comment
Contributor
There was a problem hiding this comment.
- Could you add an entry to the changelog?
- I'm inclined to make more of these components private. I have an idea of how we might be able to decide public / private / test -- would you like me to give it a shot?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
rcannood
suggested changes
May 16, 2025
rcannood
left a comment
rcannood
left a comment
Contributor
There was a problem hiding this comment.
LGTM if a changelog entry is added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Add scope to configs
Issue ticket number and link
Closes #xxxx (Replace xxxx with the GitHub issue number)Checklist before requesting a review
I have performed a self-review of my code
Conforms to the Contributor's guide
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI tests succeed!