Skip to content

Deprecate download_file#1015

Merged
rcannood merged 2 commits into
mainfrom
deprecate_download_file
May 16, 2025
Merged

Deprecate download_file#1015
rcannood merged 2 commits into
mainfrom
deprecate_download_file

Conversation

@DriesSchaumont

@DriesSchaumont DriesSchaumont commented May 2, 2025

Copy link
Copy Markdown
Member

Changelog

Deprecate download_file

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@DriesSchaumont DriesSchaumont changed the title Deprecate download_file Deprecate download_file May 2, 2025
@DriesSchaumont DriesSchaumont marked this pull request as ready for review May 2, 2025 08:43
rcannood

This comment was marked as duplicate.

@rcannood rcannood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcannood rcannood merged commit 5fb9b54 into main May 16, 2025
4 checks passed
@rcannood rcannood deleted the deprecate_download_file branch May 16, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants