Add optional quantile filtering to sample processing workflows#1148
Closed
dorien-er wants to merge 52 commits into
Closed
Add optional quantile filtering to sample processing workflows#1148dorien-er wants to merge 52 commits into
dorien-er wants to merge 52 commits into
Conversation
…flow-with-quantile-filtering
…flow-with-quantile-filtering
DriesSchaumont
requested changes
Apr 28, 2026
DriesSchaumont
left a comment
DriesSchaumont
left a comment
Member
There was a problem hiding this comment.
I think something went wrong when merging main into this PR
DriesSchaumont
requested changes
Apr 29, 2026
DriesSchaumont
requested changes
Apr 29, 2026
| def new_state = state + ["workflow_output": state.output] | ||
| [id, new_state] | ||
| } | ||
| | qc.run( |
Member
There was a problem hiding this comment.
My bad, I read this wrong! Thought all QC metrics were calculated which would be double work.
So this only calculates total_counts when quantile based filtering is enabled right? If so, it might be a good idea to move the if statement to the .run instead of fromState
dorien-er
changed the title
dorien-er
changed the title
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
#1146 and #1147 need to be merged first.Updates
rna_singlesample,prot_singlesample,process_singlesampleandprocess_sampleswith the option to filter counts by percentile.Issue ticket number and link
Closes #xxxx (Replace xxxx with the GitHub issue number)
Checklist before requesting a review
I have performed a self-review of my code
Conforms to the Contributor's guide
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI tests succeed!