Skip to content

float32 conversion for cosmx metrics #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dorien-er merged 2 commits into from
Feb 3, 2026
Merged

float32 conversion for cosmx metrics #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edd4292
float conversion
dorien-er Feb 3, 2026
8b85ab5
update changelog
dorien-er Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# openpipeline_qc 0.2.2

## BUG FIX

* `src/ingestion_qc/h5mu_to_qc_json`: Use float32 instead of float16 for CosMx staining metrics to prevent overflow to infinity (PR #17).

# openpipeline_qc 0.2.0

## NEW FEATURES
Expand Down
2 changes: 1 addition & 1 deletion src/ingestion_qc/h5mu_to_qc_json/script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ def format_cosmx_columns(mod_obs):
if key in mod_obs:
if not pd.api.types.is_float_dtype(mod_obs[key]):
try:
mod_obs[key] = mod_obs[key].astype("float16")
mod_obs[key] = mod_obs[key].astype("float32")
except ValueError:
logger.warning(f"Could not convert column {key} to a float dtype.")

Expand Down