Fix incorrect build architectures in GitHub Actions#98
Open
doblon8 wants to merge 3 commits intoopenpnp:masterfrom
Open
Fix incorrect build architectures in GitHub Actions#98doblon8 wants to merge 3 commits intoopenpnp:masterfrom
doblon8 wants to merge 3 commits intoopenpnp:masterfrom
Conversation
- Replace matrix runner variables with explicit runner labels for each job - Ensure correct runner types are used for macOS, Windows, and Ubuntu jobs
Author
|
As shown below, the architectures now match the expected targets: Note: I couldn’t verify the macOS x86_64 artifact, because I'm using a free GitHub account that doesn't allow me to run large images. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the problems with CI builds for macOS x86_64 and Linux arm64 binaries, as reported in issue #97.
Previously, some jobs were using runner images that did not match the intended target architecture:
As a result, the macOS x86_64 and Linux arm64 binaries were built with the wrong architecture.
This change assigns the correct runner image to each job so that builds match their intended targets.
Additionally, the matrix strategy has been removed since each job only used a single configuration, and
os/archare now defined viaenvto keep the existing steps unchanged.