Skip to content

Fix incorrect build architectures in GitHub Actions #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doblon8 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix incorrect build architectures in GitHub Actions #98

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d94f151
Fix incorrect build architectures in GitHub Actions
doblon8 Mar 21, 2026
fc59e3b
Remove matrix strategy in favor of env variables for os and arch
doblon8 Mar 21, 2026
40f564c
Remove erroneous extra "cmake" argument from cmake command
doblon8 Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 69 additions & 81 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
on:
on:
push:
pull_request:

jobs:
macos_x86_64:
strategy:
matrix:
os: [macos-latest]
arch: [x86_64]

runs-on: ${{ matrix.os }}
runs-on: macos-latest-large
env:
os: macos-latest
arch: x86_64
steps:
- name: Checkout Repo
uses: actions/checkout@v2
Expand All @@ -22,33 +20,29 @@ jobs:
cmake ..
make
cd ..
cp build/mac/tests/openpnp-capture-test deploy/openpnp-capture-test-${{ matrix.os }}-${{ matrix.arch }}
cp build/libopenpnp-capture.dylib deploy/libopenpnp-capture-${{ matrix.os }}-${{ matrix.arch }}.dylib
cp build/mac/tests/openpnp-capture-test deploy/openpnp-capture-test-${{ env.os }}-${{ env.arch }}
cp build/libopenpnp-capture.dylib deploy/libopenpnp-capture-${{ env.os }}-${{ env.arch }}.dylib

- name: Upload Artifacts
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.os }}-${{ matrix.arch }}
with:
name: ${{ env.os }}-${{ env.arch }}
path: |
deploy/*

- name: Create Release
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
uses: ncipollo/release-action@v1
with:
artifacts: "deploy/*"
token: ${{ secrets.GITHUB_TOKEN }}
allowUpdates: true

macos_arm64:
strategy:
matrix:
os: [macos-latest]
arch: [arm64]



runs-on: ${{ matrix.os }}
artifacts: "deploy/*"
token: ${{ secrets.GITHUB_TOKEN }}
allowUpdates: true

macos_arm64:
runs-on: macos-latest
env:
os: macos-latest
arch: arm64
steps:
- name: Checkout Repo
uses: actions/checkout@v2
Expand All @@ -61,31 +55,29 @@ jobs:
cmake ..
make
cd ..
cp build/mac/tests/openpnp-capture-test deploy/openpnp-capture-test-${{ matrix.os }}-${{ matrix.arch }}
cp build/libopenpnp-capture.dylib deploy/libopenpnp-capture-${{ matrix.os }}-${{ matrix.arch }}.dylib
cp build/mac/tests/openpnp-capture-test deploy/openpnp-capture-test-${{ env.os }}-${{ env.arch }}
cp build/libopenpnp-capture.dylib deploy/libopenpnp-capture-${{ env.os }}-${{ env.arch }}.dylib

- name: Upload Artifacts
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.os }}-${{ matrix.arch }}
with:
name: ${{ env.os }}-${{ env.arch }}
path: |
deploy/*

- name: Create Release
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
uses: ncipollo/release-action@v1
with:
artifacts: "deploy/*"
token: ${{ secrets.GITHUB_TOKEN }}
allowUpdates: true

windows_x86_64:
strategy:
matrix:
os: [windows-latest]
arch: [x86_64]

runs-on: ${{ matrix.os }}
artifacts: "deploy/*"
token: ${{ secrets.GITHUB_TOKEN }}
allowUpdates: true

windows_x86_64:
runs-on: windows-latest
env:
os: windows-latest
arch: x86_64
steps:
- name: Checkout Repo
uses: actions/checkout@v2
Expand All @@ -101,31 +93,29 @@ jobs:
cmake ..
cmake --build . --config Release
cd ..
cp build/win/tests/Release/openpnp-capture-test.exe deploy/openpnp-capture-test-${{ matrix.os }}-${{ matrix.arch }}.exe
cp build/Release/openpnp-capture.dll deploy/libopenpnp-capture-${{ matrix.os }}-${{ matrix.arch }}.dll
cp build/win/tests/Release/openpnp-capture-test.exe deploy/openpnp-capture-test-${{ env.os }}-${{ env.arch }}.exe
cp build/Release/openpnp-capture.dll deploy/libopenpnp-capture-${{ env.os }}-${{ env.arch }}.dll

- name: Upload Artifacts
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.os }}-${{ matrix.arch }}
with:
name: ${{ env.os }}-${{ env.arch }}
path: |
deploy/*

- name: Create Release
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
uses: ncipollo/release-action@v1
with:
artifacts: "deploy/*"
token: ${{ secrets.GITHUB_TOKEN }}
allowUpdates: true

linux_arm64:
strategy:
matrix:
os: [ubuntu-22.04]
arch: [arm64]

runs-on: ${{ matrix.os }}
artifacts: "deploy/*"
token: ${{ secrets.GITHUB_TOKEN }}
allowUpdates: true

linux_arm64:
runs-on: ubuntu-22.04-arm
env:
os: ubuntu-22.04
arch: arm64
steps:
- name: Checkout Repo
uses: actions/checkout@v2
Expand All @@ -136,34 +126,32 @@ jobs:
mkdir build
mkdir deploy
cd build
cmake -DCMAKE_BUILD_TYPE=Release cmake ..
cmake -DCMAKE_BUILD_TYPE=Release ..
make
cd ..
cp build/linux/tests/openpnp-capture-test deploy/openpnp-capture-test-${{ matrix.os }}-${{ matrix.arch }}
cp build/libopenpnp-capture.so deploy/libopenpnp-capture-${{ matrix.os }}-${{ matrix.arch }}.so
cp build/linux/tests/openpnp-capture-test deploy/openpnp-capture-test-${{ env.os }}-${{ env.arch }}
cp build/libopenpnp-capture.so deploy/libopenpnp-capture-${{ env.os }}-${{ env.arch }}.so

- name: Upload Artifacts
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.os }}-${{ matrix.arch }}
with:
name: ${{ env.os }}-${{ env.arch }}
path: |
deploy/*

- name: Create Release
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
uses: ncipollo/release-action@v1
with:
artifacts: "deploy/*"
token: ${{ secrets.GITHUB_TOKEN }}
allowUpdates: true

linux_x86_64:
strategy:
matrix:
os: [ubuntu-22.04]
arch: [x86_64]

runs-on: ${{ matrix.os }}
artifacts: "deploy/*"
token: ${{ secrets.GITHUB_TOKEN }}
allowUpdates: true

linux_x86_64:
runs-on: ubuntu-22.04
env:
os: ubuntu-22.04
arch: x86_64
steps:
- name: Checkout Repo
uses: actions/checkout@v2
Expand All @@ -174,23 +162,23 @@ jobs:
mkdir build
mkdir deploy
cd build
cmake -DCMAKE_BUILD_TYPE=Release cmake ..
cmake -DCMAKE_BUILD_TYPE=Release ..
make
cd ..
cp build/linux/tests/openpnp-capture-test deploy/openpnp-capture-test-${{ matrix.os }}-${{ matrix.arch }}
cp build/libopenpnp-capture.so deploy/libopenpnp-capture-${{ matrix.os }}-${{ matrix.arch }}.so
cp build/linux/tests/openpnp-capture-test deploy/openpnp-capture-test-${{ env.os }}-${{ env.arch }}
cp build/libopenpnp-capture.so deploy/libopenpnp-capture-${{ env.os }}-${{ env.arch }}.so

- name: Upload Artifacts
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.os }}-${{ matrix.arch }}
with:
name: ${{ env.os }}-${{ env.arch }}
path: |
deploy/*

- name: Create Release
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
uses: ncipollo/release-action@v1
with:
artifacts: "deploy/*"
token: ${{ secrets.GITHUB_TOKEN }}
allowUpdates: true
artifacts: "deploy/*"
token: ${{ secrets.GITHUB_TOKEN }}
allowUpdates: true