Skip to content

Fix DNS retrieval to use active provider (Sectigo/Openprovider)#539

Open
YumeChaan wants to merge 3 commits into
masterfrom
INTGRTNS-495-Zones-with-premium-name-servers-are-getting-duplicated-in-RCP-when-adding-zone-records
Open

Fix DNS retrieval to use active provider (Sectigo/Openprovider)#539
YumeChaan wants to merge 3 commits into
masterfrom
INTGRTNS-495-Zones-with-premium-name-servers-are-getting-duplicated-in-RCP-when-adding-zone-records

Conversation

@YumeChaan

Copy link
Copy Markdown
Collaborator

Fix DNS retrieval to use active provider instead of default Openprovider

Copilot AI review requested due to automatic review settings May 4, 2026 07:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the OpenProvider registrar integration so DNS zone retrieval chooses the active DNS provider for a domain, instead of always querying the default Openprovider zone. In the broader codebase, this affects the WHMCS-side DNS management flow that reads zone records through ApiHelper.

Changes:

  • Fetch domain metadata before DNS retrieval to infer which provider owns the active zone.
  • Pass the resolved provider into retrieveZoneDnsRequest.
  • Add a helper that maps domain metadata to either sectigo or openprovider.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread modules/registrars/openprovider/OpenProvider/API/ApiHelper.php Outdated
Comment thread modules/registrars/openprovider/OpenProvider/API/ApiHelper.php Outdated
@YumeChaan

Copy link
Copy Markdown
Collaborator Author

An additional domain lookup is required to determine the active DNS provider, as this information is not available from DNS zone APIs. This ensures correct handling of domains using Sectigo DNS instead of defaulting to Openprovider.

Provider detection is handled internally within ApiHelper for consistency across retrieve, update, and delete operations. A fallback to Openprovider is used if domain lookup fails, to avoid blocking DNS operations due to temporary lookup issues.

Zone creation intentionally does not use provider detection and defaults to Openprovider.

YumeChaan added 2 commits May 6, 2026 10:08
…with-premium-name-servers-are-getting-duplicated-in-RCP-when-adding-zone-records
@YumeChaan YumeChaan requested a review from avishka-ra May 6, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants