Skip to content

Fix DNS retrieval to use active provider (Sectigo/Openprovider) #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YumeChaan wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix DNS retrieval to use active provider (Sectigo/Openprovider) #539

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8074550
Fix DNS retrieval to use active provider (Sectigo/Openprovider)
YumeChaan May 4, 2026
afdd805
updated code for update/delete
YumeChaan May 6, 2026
c9b4d97
Merge remote-tracking branch 'origin/master' into INTGRTNS-495-Zones-…
YumeChaan May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion modules/registrars/openprovider/OpenProvider/API/ApiHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,12 +415,20 @@ public function deleteNameserver(string $nameServerName): array
*/
public function getDns(Domain $domain): array
{

$domainData = $this->getDomain($domain);

$provider = $this->getDnsProviderFromDomainData($domainData);
logModuleCall('OpenProvider', 'getDns', $domain->getFullName(), ['provider' => $provider], null, null);
$args = [
'name' => $domain->getFullName(),
'provider' => $provider,
Comment thread
YumeChaan marked this conversation as resolved.
Outdated
'withHistory' => false,
];

Comment thread
YumeChaan marked this conversation as resolved.
Outdated
return $this->buildResponse($this->apiClient->call('retrieveZoneDnsRequest', $args));
return $this->buildResponse(
$this->apiClient->call('retrieveZoneDnsRequest', $args)
);
}

/**
Expand Down Expand Up @@ -717,6 +725,26 @@ public function supportsDnssec(string $tld): bool
}
}


/**
* @param array $domainData
* @return string
*/
private function getDnsProviderFromDomainData(array $domainData): string
{
$nsGroup = strtolower((string) ($domainData['nsGroup'] ?? ''));

if (
($domainData['hasActiveSectigoZone'] ?? false) === true ||
($domainData['isSectigoDnsEnabled'] ?? false) === true ||
str_contains($nsGroup, 'sectigo')
) {
return 'sectigo';
}

return 'openprovider';
}

/**
* @param ResponseInterface $response
* @return array
Expand Down