Skip to content

Conversation

@xkopenreview
Copy link
Collaborator

changes of #2288 based on nextjs 15 (v1.14.0)

@racheljsmart
Copy link
Contributor

continuing the discussion about the fields in the feedback form..

As long as the user's can enter the venue ID in the form (a text box with an example venue ID) I don't think we need the dropdown if the list is too long.

Including role as a textbox would be helpful, and we can also include an example.

@melisabok melisabok requested review from enrubio and melisabok June 30, 2025 15:22
@melisabok
Copy link
Member

When I try to submit a feedback as a guest user, I get this error:

The Invitation openreview.net/-/Feedback was not found

What is this invitation for?

@melisabok
Copy link
Member

I think offering only these 4 options is too limited:

Screenshot 2025-06-30 at 11 44 18 AM

Could we include cases like:

  • the user is a reviewer or member of the committee
  • the user is trying to create their profile
  • the user is trying to access to a publication

@xkopenreview
Copy link
Collaborator Author

When I try to submit a feedback as a guest user, I get this error:

The Invitation openreview.net/-/Feedback was not found

What is this invitation for?

this is the invitation to send feedback
https://github.com/openreview/openreview-api/pull/89/files#diff-40f517b1f896b7521f0ab024e4e61a7eaa1190177b6a024bc21be902ff85c5adR58

@melisabok
Copy link
Member

If I have a question about my profile, it is asking the venue id, can this be optional? some users might to register to openreview to read papers.

Screenshot 2025-06-30 at 1 03 10 PM

@melisabok
Copy link
Member

if the user is logged in, can we prepopulate the email textfield with the preferred email or tilde id?

@racheljsmart
Copy link
Contributor

I like the subject options that are added.

@enrubio
Copy link
Member

enrubio commented Jul 1, 2025

The form looks great. I see we have 2 dropdown options relating to profiles: My OpenReview Profile and I am trying to create my profile. I feel we can have just one profile related option, maybe the first one. What do you think?

@melisabok
Copy link
Member

Some users are already registered in OpenReview and they may have issues with their existing profile so I would keep both.

@enrubio
Copy link
Member

enrubio commented Jul 1, 2025

Are we not allowing guests to contact us through the feedback form? I see: Error: signature must match pattern "^~.+\d+$|.+@.+\..+|^(guest)$".

I have a test email in the Your email address field.

@melisabok
Copy link
Member

Are you testing this using pytest? I think I'm not escaping (guest) correctly in the regex: https://github.com/openreview/openreview-api-v1/pull/3045/files

If you edit the openreview.net/-/Feedback invitation, and add \(guest\), it should work. Like here: https://openreview.net/invitation/edit?id=OpenReview.net/-/Feedback

@emily-grabowski
Copy link
Contributor

I suggest renaming the following option:

  • 'My OpenReview profile' --> I have a question about my existing OpenReview profile
    so that users know which one to choose of the profile options

My other suggestion would be to ask what someone's role is in a venue (Author, Reviewer, Area Chair, etc), but I would understand if this adds too much complexity

@melisabok
Copy link
Member

My other suggestion would be to ask what someone's role is in a venue (Author, Reviewer, Area Chair, etc), but I would understand if this adds too much complexity

There is one option for authors and a new option for member of the reviewing committee.

@enrubio
Copy link
Member

enrubio commented Jul 2, 2025

I am using a pytest, but I don't see an openreview.net/-/Feedback invitation in my local. Did you create it? I'm able to send messages through the form though without one.

@enrubio
Copy link
Member

enrubio commented Jul 2, 2025

Okay I confirmed the issue with the regex for guest users. I made the change to the invitation in Safari, I think Chrome is capitalizing openreview. I changed the regex to use: ^\\(guest\\)$ and was able to use the form.

Other than that the PR looks good! I'll wait for the fix in the API before merging.

@melisabok melisabok merged commit 57a53d2 into master Jul 2, 2025
2 checks passed
@melisabok melisabok deleted the fix/contact-nextjs branch July 2, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants