-
Notifications
You must be signed in to change notification settings - Fork 9
Fix/ Remove the info email from the Contact page (nextjs15) #2324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
continuing the discussion about the fields in the feedback form.. As long as the user's can enter the venue ID in the form (a text box with an example venue ID) I don't think we need the dropdown if the list is too long. Including role as a textbox would be helpful, and we can also include an example. |
|
When I try to submit a feedback as a guest user, I get this error: What is this invitation for? |
this is the invitation to send feedback |
|
if the user is logged in, can we prepopulate the email textfield with the preferred email or tilde id? |
|
I like the subject options that are added. |
|
The form looks great. I see we have 2 dropdown options relating to profiles: |
|
Some users are already registered in OpenReview and they may have issues with their existing profile so I would keep both. |
|
Are we not allowing guests to contact us through the feedback form? I see: I have a test email in the |
|
Are you testing this using pytest? I think I'm not escaping (guest) correctly in the regex: https://github.com/openreview/openreview-api-v1/pull/3045/files If you edit the openreview.net/-/Feedback invitation, and add \(guest\), it should work. Like here: https://openreview.net/invitation/edit?id=OpenReview.net/-/Feedback |
|
I suggest renaming the following option:
My other suggestion would be to ask what someone's role is in a venue (Author, Reviewer, Area Chair, etc), but I would understand if this adds too much complexity |
There is one option for authors and a new option for member of the reviewing committee. |
|
I am using a pytest, but I don't see an |
|
Okay I confirmed the issue with the regex for guest users. I made the change to the invitation in Safari, I think Chrome is capitalizing Other than that the PR looks good! I'll wait for the fix in the API before merging. |


changes of #2288 based on nextjs 15 (v1.14.0)