remove guava dependency

[jngz-es]

Description

As a common extensible plugin, remove guava dependency to reduce jar hell or conflicts issues caused by guava in extending plugins like SQL, ML etc.

Related Issues

opensearch-project/OpenSearch#18113

Check List

• New functionality includes testing.
• New functionality has been documented.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[andrross]

I think the whole section above this can go too:

configurations {
    all {
        resolutionStrategy {
            force 'com.google.guava:guava:32.1.3-jre'
        }
    }
}

Also what about the section below?

    //spotless
    implementation('com.google.googlejavaformat:google-java-format:1.26.0') {
        exclude group: 'com.google.guava'
    }

[jngz-es]

Good catch, I am removing them as well.

[andrross]

This makes sense to me! The JDK now natively supports these immutable collections so no need to bring in guava just to get ImmutableList and ImmutableMap.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.67%. Comparing base (f508936) to head (8de1383).
Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (37.67%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff            @@
##               main     #773   +/-   ##
=========================================
  Coverage     37.67%   37.67%           
  Complexity      135      135           
=========================================
  Files            22       22           
  Lines          1189     1189           
  Branches        109      109           
=========================================
  Hits            448      448           
  Misses          704      704           
  Partials         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[prudhvigodithi]

Thanks @jngz-es thanks for this change. Same as what Andrew mentioned, I have tested with List.of and behaves the same

List<String> immutable = List.of("a", "b", "c");
immutable.add("d"); // this throws exception.

[kaituo]

CI failed. Can you take a look?

[kaituo]

rerun CI

[cwperks]

I support removing guava from this plugin, but also wanted to leave insight I found out about extensible plugins recently.

When pluginA extends pluginB, all of pluginBs deps are available to pluginA at runtime, however they are not available at compile time

Because of this, plugins like AD are able to specify compileOnly dependencies on guava and know that they are available at runtime because of their extension on JS plugin.

The key is to ensure there is a version catalog to keep these common deps in sync.

[cwperks]

@kaituo make sure to update AD from compileOnly to implementation for the guava deps now that this change is merged.

[cwperks]

@kaituo make sure to update AD from compileOnly to implementation for the guava deps now that this change is merged.

@kaituo I raised opensearch-project/anomaly-detection#1473 to address this