Remove manual tracking of seqNo and priTerm for the LockModel #822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes manual tracking of seqNo and priTerm for the LockModel. This repo doesn't use these values as intended and they serve no real purpose, the LockModel can be simplified to just the attributes pertinent to the LockModel. seqNo and priTerm and internal metafields of documents in OpenSearch that help understand if a document has previously been updated or if the primary shard has changed.
In the LockService, we always call findLock before updateLock so we simply feed back the same values that we got on find. I suppose it is possible that an operator can use the admin certificate to do a direct lock update which would then cause a mismatch of the seqNos but I think we should allow the lock to be acquired/released by the LockService anyway and run without checks on the seqNo and priTerm.
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.