Declare credential.openai_key as sensitive param in create connector API #4308
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
cwperks
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
cwperks
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
cwperks
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR marks
credential.openai_keyas sensitive param in create connector API.The RestRequestFilter is a currently unused interface in the core repository that can be used to declare API params as sensitive.
This PR marks the keys from https://docs.opensearch.org/latest/tutorials/gen-ai/rag/conversational-search-openai/#step-1-create-a-connector-and-register-the-model as keys that should be filtered in the event the request body is ever used anywhere.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.