Skip to content

Declare credential.openai_key as sensitive param in create connector API #4308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Declare credential.openai_key as sensitive param in create connector API #4308

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62a1b18
Declare credential.openai_key as sensitive param in create connector API
cwperks Oct 13, 2025
cf0c5bf
Do the same for headers
cwperks Oct 13, 2025
9bbfcf7
Revert actions.headers
cwperks Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion plugin/src/main/java/org/opensearch/ml/rest/RestMLCreateConnectorAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import java.io.IOException;
import java.util.List;
import java.util.Locale;
import java.util.Set;

import org.opensearch.core.xcontent.XContentParser;
import org.opensearch.ml.common.settings.MLFeatureEnabledSetting;
Expand All @@ -21,13 +22,14 @@
import org.opensearch.ml.common.transport.connector.MLCreateConnectorRequest;
import org.opensearch.rest.BaseRestHandler;
import org.opensearch.rest.RestRequest;
import org.opensearch.rest.RestRequestFilter;
import org.opensearch.rest.action.RestToXContentListener;
import org.opensearch.transport.client.node.NodeClient;

import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.ImmutableList;

public class RestMLCreateConnectorAction extends BaseRestHandler {
public class RestMLCreateConnectorAction extends BaseRestHandler implements RestRequestFilter {
private static final String ML_CREATE_CONNECTOR_ACTION = "ml_create_connector_action";
private final MLFeatureEnabledSetting mlFeatureEnabledSetting;

Expand Down Expand Up @@ -76,4 +78,9 @@ MLCreateConnectorRequest getRequest(RestRequest request) throws IOException {
mlCreateConnectorInput.setTenantId(tenantId);
return new MLCreateConnectorRequest(mlCreateConnectorInput);
}

@Override
public Set<String> getFilteredFields() {
return Set.of("credential.openai_key");
}
}