Changes to support ramp-up feature#725
Merged
rishabh6788 merged 3 commits intoopensearch-project:mainfrom Jan 15, 2025
Merged
Conversation
Signed-off-by: Rishabh Singh <sngri@amazon.com>
OVI3D0
approved these changes
Jan 14, 2025
Member
OVI3D0
left a comment
OVI3D0
left a comment
There was a problem hiding this comment.
LGTM, apart from the linter errors of course. I ran this locally and all the unit tests pass otherwise.
Also, should the documentation be updated to include this new ramp up time period property?
Collaborator
Author
Thank you. Yes, I'm working on a doc that explains how to use this feature. |
IanHoang
reviewed
Jan 14, 2025
IanHoang
approved these changes
Jan 14, 2025
Collaborator
IanHoang
left a comment
IanHoang
left a comment
There was a problem hiding this comment.
Left one question but functionality looks good to me
rishabh6788
requested review from
VijayanB,
beaioun and
gkamat
as code owners
rishabh6788
force-pushed
the
ramp-up
branch
2 times, most recently
from
776b750 to
372439f
Compare
Signed-off-by: Rishabh Singh <sngri@amazon.com>
Signed-off-by: Rishabh Singh <sngri@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #713 this PR introduces a new task property, ramp-up-time-period. When provided, opensearch-benchmark will gradually scale up clients based on the time-period and number of clients provided.
Issues Resolved
#713
Testing
[Describe how this change was tested]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.