fix Integration test failed for default data source #1850
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qxisylolo <[email protected]>
Qxisylolo
force-pushed
the
fix/default_ds_tests
branch
from
d1f6901 to
70a77a5
Compare
Qxisylolo
requested review from
CCongWang,
Hailong-am,
SuZhou-Joe,
ananzh,
ashwin-pc,
kavilla,
ohltyler,
peterzhuamazon,
prudhvigodithi,
raintygao,
ruanyl,
tianleh,
wanglam,
xluo-aws,
yubonluo,
yujin-emma and
zhongnansu
as code owners
Hailong-am
reviewed
Oct 9, 2025
Comment on lines
-13
to
+18
| // Clean up before creating new data sources for testing | ||
| cy.deleteAllDataSourcesOnUI(); | ||
| // Clean up after all test are run | ||
| cy.deleteAllDataSources(); | ||
| // remove the default data source | ||
| cy.setAdvancedSetting({ | ||
| defaultDataSource: '', | ||
| }); |
There was a problem hiding this comment.
what's the behavor of delete datasource on ui about the datasource
There was a problem hiding this comment.
In my local testing, both methods work, but deleting the data source in the UI behaves inconsistently and results in flaky errors more often
|
The CI group 4 failed due to a modal in home page, irrelevant to the changes of this PR. |
SuZhou-Joe
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes Integration test failed for default data source.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.