Skip to content

fix Integration test failed for default data source #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix Integration test failed for default data source #1850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...oards/opensearch-dashboards/datasource-management-plugin/4_set_default_datasource.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,12 @@ const miscUtils = new MiscUtils(cy);
if (Cypress.env('DATASOURCE_MANAGEMENT_ENABLED')) {
describe('Default data sources', () => {
before(() => {
// Clean up before creating new data sources for testing
cy.deleteAllDataSourcesOnUI();
// Clean up after all test are run
cy.deleteAllDataSources();
// remove the default data source
cy.setAdvancedSetting({
defaultDataSource: '',
});
Comment on lines -13 to +18
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the behavor of delete datasource on ui about the datasource

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my local testing, both methods work, but deleting the data source in the UI behaves inconsistently and results in flaky errors more often

});

describe('The default data source can behave normal when edit data source table', () => {
Expand Down
Loading