fix CVE issues - #2068
Merged
Merged
Conversation
yyfamazon
requested review from
CCongWang,
Hailong-am,
Maosaic,
SuZhou-Joe,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
kavilla,
ohltyler,
peterzhuamazon,
prudhvigodithi,
ruanyl,
sejli,
wanglam,
xluo-aws,
yubonluo,
yujin-emma and
zhongnansu
as code owners
June 22, 2026 03:00
Signed-off-by: yyfamazon <yyf@amazon.com>
Signed-off-by: yyfamazon <yyf@amazon.com>
Signed-off-by: yyfamazon <yyf@amazon.com>
wanglam
approved these changes
Jun 22, 2026
yyfamazon
force-pushed
the
main
branch
2 times, most recently
from
June 22, 2026 09:44
391dad6 to
cf997df
Compare
Signed-off-by: yyfamazon <yyf@amazon.com>
SuZhou-Joe
reviewed
Jun 22, 2026
| "form-data": "^2.5.5" | ||
| "form-data": "^2.5.5", | ||
| "lodash": "^4.18.0", | ||
| "flatted": "^3.4.0", |
Member
There was a problem hiding this comment.
Do we use flatted as direct dependency?
Contributor
Author
There was a problem hiding this comment.
No, flatted is not a direct dependency. It's a transitive dependency pulled in through:
eslint → file-entry-cache → flat-cache → flatted
It only appears in overrides and resolutions to force the patched version for the CVE fix.
Member
There was a problem hiding this comment.
Oh, get it. I thought it was for dev dependency. Thanks.
ruanyl
approved these changes
Jun 22, 2026
ruanyl
self-requested a review
June 22, 2026 10:09
Signed-off-by: yyfamazon <yyf@amazon.com>
SuZhou-Joe
approved these changes
Jun 22, 2026
1 task
TackAdam
pushed a commit
to TackAdam/opensearch-dashboards-functional-test
that referenced
this pull request
Jun 25, 2026
The CVE-fix commit (opensearch-project#2068) migrated this repo from yarn to npm. Under npm, the reporters' mocha peerDependency auto-installs a top-level mocha@11, which conflicts with Cypress 13.17's bundled mocha@7.0.1 and breaks the reporter (test.slow is not a function). Pin mocha to 7.0.1 via overrides so both cypress-multi-reporters and mocha-junit-reporter resolve against the same mocha Cypress runs. Lockfile is updated incrementally from the working main lockfile so it stays in sync (npm ci) and keeps ajv@8.20.0 top-level with eslint's nested ajv@6.15.0 (lint passes).
TackAdam
pushed a commit
to TackAdam/opensearch-dashboards-functional-test
that referenced
this pull request
Jun 25, 2026
The CVE-fix commit (opensearch-project#2068) migrated this repo from yarn to npm. Under npm, the reporters' mocha peerDependency auto-installs a top-level mocha@11, which conflicts with Cypress 13.17's bundled mocha@7.0.1 and breaks the reporter (test.slow is not a function). Pin mocha to 7.0.1 via overrides so both cypress-multi-reporters and mocha-junit-reporter resolve against the same mocha Cypress runs. Lockfile is updated incrementally from the working main lockfile so it stays in sync (npm ci) and keeps ajv@8.20.0 top-level with eslint's nested ajv@6.15.0 (lint passes). Signed-off-by: Adam Tackett <tackadam@amazon.com>
peterzhuamazon
pushed a commit
that referenced
this pull request
Jun 26, 2026
* fix obs test failures: pin mocha to Cypress bundled version The CVE-fix commit (#2068) migrated this repo from yarn to npm. Under npm, the reporters' mocha peerDependency auto-installs a top-level mocha@11, which conflicts with Cypress 13.17's bundled mocha@7.0.1 and breaks the reporter (test.slow is not a function). Pin mocha to 7.0.1 via overrides so both cypress-multi-reporters and mocha-junit-reporter resolve against the same mocha Cypress runs. Lockfile is updated incrementally from the working main lockfile so it stays in sync (npm ci) and keeps ajv@8.20.0 top-level with eslint's nested ajv@6.15.0 (lint passes). Signed-off-by: Adam Tackett <tackadam@amazon.com> * Pin dorny/paths-filter to commit SHA in dashboard-variable workflow This workflow was missed in c791b5b (Pin GitHub Actions to commit SHAs). The org policy rejects unpinned actions, failing the 'changes' job. Use the same SHA (4512585405083f25c027a35db413c2b3b9006d50 # v2) already used by the other 20 e2e workflows. Signed-off-by: Adam Tackett <tackadam@amazon.com> --------- Signed-off-by: Adam Tackett <tackadam@amazon.com> Co-authored-by: Adam Tackett <tackadam@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses multiple security vulnerabilities in dependencies and hardens CI workflow actions by pinning them to specific commit SHAs.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.