Skip to content

Resolve TOCTOU race condition in daily forecaster chart control click #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterzhuamazon merged 1 commit into from
Aug 1, 2026
Merged

Resolve TOCTOU race condition in daily forecaster chart control click #2127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions cypress/integration/plugins/anomaly-detection-dashboards-plugin/daily_forecaster_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,16 @@ const clickControlAndVerifyChartUpdate = (buttonAriaLabel) => {
cy.get('.echChartStatus')
.invoke('attr', 'data-ech-render-count')
.then((initialRenderCount) => {
cy.get(`button[aria-label="${buttonAriaLabel}"]`).click();

// Cypress's .should() will automatically retry until the assertion passes or times out,
// which handles the async nature of the re-render.
cy.get('.echChartStatus')
.invoke('attr', 'data-ech-render-count')
.should('not.eq', initialRenderCount);
// Re-check disabled state right before clicking to avoid TOCTOU race
cy.get(`button[aria-label="${buttonAriaLabel}"]`).then(($btn) => {
if (!$btn.is(':disabled')) {
cy.wrap($btn).click();

cy.get('.echChartStatus')
.invoke('attr', 'data-ech-render-count')
.should('not.eq', initialRenderCount);
}
});
});
}
});
Expand Down
Loading