Resolve TOCTOU race condition in daily forecaster chart control click - #2127
Merged
peterzhuamazon merged 1 commit intoAug 1, 2026
Conversation
…click Signed-off-by: shreyah963 <shreyab963@gmail.com>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
rishabh6788
approved these changes
Aug 1, 2026
shreyah963
marked this pull request as ready for review
August 1, 2026 04:00
shreyah963
requested review from
CCongWang,
Hailong-am,
Maosaic,
SuZhou-Joe,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
kavilla,
ohltyler,
peterzhuamazon,
prudhvigodithi,
ruanyl,
sejli,
wanglam,
xluo-aws,
yubonluo,
yujin-emma and
zhongnansu
as code owners
August 1, 2026 04:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a race condition in
daily_forecaster_spec.jswhereclickControlAndVerifyChartUpdatefails withcy.click() failed because this element is disabledon the "Zoom out" button.The outer
$body.find(":not(:disabled)")guard (line 32) is a synchronous jQuery snapshot. Between that check and the actualcy.get().click()(line 39), the async echChartStatus render-count fetch allows time for the chart to re-render and disable the button. Cypress then retries.click()on the disabled element until it times out.Fix: Re-check
:disabledstate immediately before clicking usingcy.get().then($btn), and only proceed with the click and render-count assertion if the button is still enabled. This eliminates the TOCTOU (time-of-check-to-time-of-use) gap.Issues Resolved
opensearch-project/anomaly-detection-dashboards-plugin#1224
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.