Skip to content

Conversation

Jakob3xD
Copy link
Collaborator

@Jakob3xD Jakob3xD commented Oct 7, 2025

Description

  • Update golangci-lint
  • fix linting complains

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.33%. Comparing base (06a6dc8) to head (c97c0ba).
⚠️ Report is 116 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
+ Coverage   57.29%   60.33%   +3.03%     
==========================================
  Files         315      377      +62     
  Lines        9823    11694    +1871     
==========================================
+ Hits         5628     7055    +1427     
- Misses       2902     3204     +302     
- Partials     1293     1435     +142     
Flag Coverage Δ
integration 52.84% <100.00%> (+2.00%) ⬆️
unit 14.92% <ø> (+2.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/test/helper.go 65.97% <100.00%> (ø)
opensearchapi/api_aliases.go 100.00% <ø> (ø)
opensearchapi/api_bulk.go 100.00% <ø> (ø)
opensearchapi/api_cat-aliases.go 100.00% <ø> (ø)
opensearchapi/api_cat-allocation.go 100.00% <ø> (ø)
opensearchapi/api_cat-cluster_manager.go 100.00% <ø> (ø)
opensearchapi/api_cat-count.go 100.00% <ø> (ø)
opensearchapi/api_cat-fielddata.go 100.00% <ø> (ø)
opensearchapi/api_cat-health.go 100.00% <ø> (ø)
opensearchapi/api_cat-indices.go 100.00% <ø> (ø)
... and 173 more

... and 53 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jakob3xD Jakob3xD marked this pull request as ready for review October 7, 2025 14:16
@Jakob3xD
Copy link
Collaborator Author

Jakob3xD commented Oct 9, 2025

@VijayanB do you have time reviewing this?
Doing the review commit by commit should be easier to read.

@dblock dblock merged commit a647d62 into opensearch-project:main Oct 9, 2025
104 of 105 checks passed
@Jakob3xD Jakob3xD deleted the old-ci-lint branch October 9, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants