Skip to content

Fix BWC tests which haven't been run (noop) - #237

Merged
akash-shankaran merged 2 commits into
opensearch-project:mainfrom
reta:fix.bwc.noop
Jan 23, 2026
Merged

Fix BWC tests which haven't been run (noop)#237
akash-shankaran merged 2 commits into
opensearch-project:mainfrom
reta:fix.bwc.noop

Conversation

@reta

@reta reta commented Jan 16, 2026

Copy link
Copy Markdown
Collaborator

Description

Fix BWC tests which haven't been run (noop)

Related Issues

Fix BWC tests which haven't been run (noop). I think the Gradle update (one of 9.x line) is the culprit, we have observed that across different projects. Caused by https://docs.gradle.org/9.0.0/userguide/upgrading_major_version_9.html?_gl=1*qw3vru*_gcl_au*NzgyNzg1MTEwLjE3Njg1MjcwMDI.*_ga*MTI0MDE1MzA2OC4xNzY4NTI3MDAy*_ga_7W7NC6YNPT*czE3Njg1MjcwMDIkbzEkZzAkdDE3Njg1MjcwMDIkajYwJGwwJGgw#test_tasks_may_no_longer_execute_expected_tests

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
reta force-pushed the fix.bwc.noop branch 3 times, most recently from b2baf8d to 355130e Compare January 21, 2026 20:48
Comment thread src/testFixtures/java/org/opensearch/knn/KNNRestTestCase.java
Comment thread src/test/java/org/opensearch/knn/index/engine/JVectorEngineIT.java
Comment thread src/test/java/org/opensearch/knn/index/engine/LuceneEngineIT.java
@reta
reta force-pushed the fix.bwc.noop branch 5 times, most recently from 17ce0ca to 7e71ea5 Compare January 22, 2026 14:46
@reta
reta force-pushed the fix.bwc.noop branch 3 times, most recently from 0577a23 to 8dad7da Compare January 22, 2026 15:31
Signed-off-by: Andriy Redko <drreta@gmail.com>
Comment thread gradle.properties Outdated
Comment thread qa/restart-upgrade/src/test/java/org/opensearch/knn/bwc/IndexingIT.java Outdated
Signed-off-by: Akash Shankaran <akash.shankaran@ibm.com>
@akash-shankaran
akash-shankaran merged commit d3c74b2 into opensearch-project:main Jan 23, 2026
6 checks passed
akash-shankaran added a commit to akash-shankaran/opensearch-jvector that referenced this pull request Feb 6, 2026
* Fix BWC tests which haven't been run (noop)

Signed-off-by: Andriy Redko <drreta@gmail.com>

* Apply suggestions from code review

Signed-off-by: Akash Shankaran <akash.shankaran@ibm.com>

---------

Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Akash Shankaran <akash.shankaran@ibm.com>
Co-authored-by: Akash Shankaran <akash.shankaran@ibm.com>
Signed-off-by: akash shankaran <akash.shankaran1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants