Refactor/ipa telco kpis prow migration test infrastructure refactoring#465
Merged
Conversation
openshift-ci
Bot
added
the
needs-rebase
ccardenosa
force-pushed
the
refactor/ipa-telco-kpis-prow-migration-test-infrastructure-refactoring
branch
from
47a6c77 to
be22e63
Compare
openshift-ci
Bot
removed
the
needs-rebase
ccardenosa
force-pushed
the
refactor/ipa-telco-kpis-prow-migration-test-infrastructure-refactoring
branch
9 times, most recently
from
ee30d22 to
02fc5f3
Compare
ccardenosa
force-pushed
the
refactor/ipa-telco-kpis-prow-migration-test-infrastructure-refactoring
branch
6 times, most recently
from
e33fdb3 to
2775651
Compare
Implement shared roles and modules to eliminate code duplication and standardize Telco-KPIs test implementations. **playbooks/telco-kpis/roles/artifact-management/** - Eliminates duplicate artifact collection code across all tests - Standardized artifact workflow: collect → generate JUnit XML → push to shared location → cleanup - Tasks: - `collect-from-bastion.yml` - Fetch artifacts from remote bastion - `generate-junit-xml.yml` - Create JUnit XML from test results - `push-to-shared.yml` - Copy to shared artifact location - `cleanup-old-artifacts.yml` - Remove temporary artifacts - Template: `junit-report.xml.j2` - Standardized JUnit XML format **playbooks/telco-kpis/roles/telco-kpis-defaults/** - Centralized default values for all telco-kpis tests - Provides consistent defaults for: - Spirent configuration (chassis, stcweb, ports, test config) - Artifact directories - Test parameters - Eliminates hardcoded values scattered across playbooks **kubernetes.core Module Migration:** - Replaced shell commands with kubernetes.core.k8s module for: - Pod deployment (dpdk-testpmd) - Resource querying - Pod deletion verification - Benefits: - Idempotent operations - Better error handling - Structured return values - No shell parsing required **Centralized Configuration:** - Default Spirent settings in telco-kpis-defaults role - Eliminates magic numbers and hardcoded IPs - Single source of truth for test parameters - **Code Reuse:** artifact-management role used across all tests - **Consistency:** Standardized artifact naming and structure - **Maintainability:** Changes to artifact workflow in one place - **Reliability:** kubernetes.core modules more robust than shell commands - **Configuration Management:** Centralized defaults easier to update All telco-kpis tests (oslat, cyclictest, ptp, cpu_util, reboot, rfc2544, bios-validation, rds-compare, ztp-timeline) benefit from these refactorings. Related: Telco-KPIs test infrastructure Signed-off-by: Carlos Cardenosa <ccardeno@redhat.com>
ccardenosa
force-pushed
the
refactor/ipa-telco-kpis-prow-migration-test-infrastructure-refactoring
branch
from
2775651 to
e1856f0
Compare
Collaborator
|
/lgtm |
Collaborator
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccardenosa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.