OCPBUGS-45888: ClusterNetworkOperator API: promote the additionalRoutingCapabilities flag to default

[fedepaol]

Promoting the feature gate as the deployed daemonset is being used by metallb and covered by MetalLB tests.

Backport of #2087

[openshift-ci]

Hello @fedepaol! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[fedepaol]

/retest

[fedepaol]

/jira backport OCPBUGS-45887

[openshift-ci-robot]

@fedepaol: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick OCPBUGS-45887

In response to this:

/jira backport OCPBUGS-45887

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of OCPBUGS-45887 in a new PR and assign it to you.

In response to this:

@fedepaol: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick OCPBUGS-45887

In response to this:

/jira backport OCPBUGS-45887

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fedepaol]

/jira cherry-pick OCPBUGS-45887

[openshift-ci-robot]

@fedepaol: Jira Issue OCPBUGS-45887 has been cloned as Jira Issue OCPBUGS-45888. Will retitle bug to link to clone.
/retitle OCPBUGS-45888: ClusterNetworkOperator API: promote the additionalRoutingCapabilities flag to default

In response to this:

/jira cherry-pick OCPBUGS-45887

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@fedepaol: This pull request references Jira Issue OCPBUGS-45888, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected dependent Jira Issue OCPBUGS-45887 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Promoting the feature gate as the deployed daemonset is being used by metallb and covered by MetalLB tests.

Backport of #2087

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[fedepaol]

/jira refresh

[openshift-ci-robot]

@fedepaol: This pull request references Jira Issue OCPBUGS-45888, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-45887 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-45887 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
• bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[fedepaol]

https://sippy.dptools.openshift.org/sippy-ng/jobs/4.18/analysis?filters=%7B%22items%22%3A%5B%7B%22columnField%22%3A%22name%22%2C%22operatorValue%22%3A%22equals%22%2C%22value%22%3A%22periodic-ci-openshift-frr-release-4.18-periodics-frrk8s-e2e-metal-cno-periodic%22%7D%5D%7D

[fedepaol]

cc @JoelSpeed

[JoelSpeed]

@fedepaol Can you please go through the bug process and make sure that we have a valid bug chain. Is there feature now complete in 4.19, and verified by QE? We cannot start the backport process until we are happy that everything is complete in 4.19

[fedepaol]

@fedepaol Can you please go through the bug process and make sure that we have a valid bug chain. Is there feature now complete in 4.19, and verified by QE? We cannot start the backport process until we are happy that everything is complete in 4.19

Ok, will do.

[fedepaol]

/jira refresh

[openshift-ci-robot]

@fedepaol: This pull request references Jira Issue OCPBUGS-45888, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-45887 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-45887 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
• bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[jcaamano]

/remove-lifecycle stale

[jcaamano]

/test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fedepaol
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@fedepaol: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify	c8c4ce3	link	true	/test verify
ci/prow/verify-crd-schema	c8c4ce3	link	true	/test verify-crd-schema
ci/prow/e2e-azure	c8c4ce3	link	false	/test e2e-azure
ci/prow/minor-e2e-upgrade-minor	c8c4ce3	link	true	/test minor-e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[JoelSpeed]

/test verify-feature-promotion

[openshift-ci]

@JoelSpeed: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test e2e-aws-ovn

/test e2e-aws-ovn-hypershift

/test e2e-aws-ovn-techpreview

/test e2e-aws-serial

/test e2e-aws-serial-techpreview

/test e2e-upgrade

/test images

/test integration

/test minor-e2e-upgrade-minor

/test minor-images

/test okd-scos-images

/test unit

/test verify

/test verify-client-go

/test verify-crd-schema

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-azure

/test e2e-gcp

/test okd-scos-e2e-aws-ovn

Use /test all to run all jobs.

In response to this:

/test verify-feature-promotion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[JoelSpeed]

Are we still wanting to promote this in 4.18? Given 4.18 has already GA'd, I suspect not?