-
Notifications
You must be signed in to change notification settings - Fork 631
OCPBUGS-54670: Use PF component group for PageHeading #14965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@logonoff: This pull request references CONSOLE-4492 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
qe review: |
@logonoff: This pull request references CONSOLE-4492 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@logonoff: This pull request references CONSOLE-4492 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@logonoff: This pull request references Jira Issue OCPBUGS-54670, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
a678243
to
1293485
Compare
/retest |
Did you all sort this out? I know i merged a PR in component groups which likely relates to this? |
Yes, we did. Thank you! |
9be97bc
to
00fe770
Compare
071e917
to
03dc8ea
Compare
Removed children
- adopt `BasePageHeading` when possible (as many pages don't use the extra functionality provided by the `connect`) - Rename `PageHeading` to `ConnectedPageHeading` - Rename `BasePageHeading` to `PageHeading` - move `PageHeading`, `Breadcrumbs` to console/shared - update cypress test to reflect changes
https://issues.redhat.com//browse/CONSOLE-4492
https://issues.redhat.com/browse/OCPBUGS-54670
follow up on #14875
adopts PF PageHeader for console's main heading component.
no major UI changes should appear in this PR (e.g., create buttons appearing in a separate row as the title), except for two: operator details now have a line between the operator icon and the operator name. badges are also now placed next to the title.
fixes small a11y issue where heading actions were inside of the
h1
element when it shouldn't be