Skip to content

OCPBUGS-54670: Use PF component group for PageHeading #14965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

logonoff
Copy link
Member

@logonoff logonoff commented Apr 12, 2025

https://issues.redhat.com//browse/CONSOLE-4492
https://issues.redhat.com/browse/OCPBUGS-54670

follow up on #14875

adopts PF PageHeader for console's main heading component.

no major UI changes should appear in this PR (e.g., create buttons appearing in a separate row as the title), except for two: operator details now have a line between the operator icon and the operator name. badges are also now placed next to the title.

fixes small a11y issue where heading actions were inside of the h1 element when it shouldn't be

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 12, 2025
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 12, 2025

@logonoff: This pull request references CONSOLE-4492 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cajieh and karthikjeeyar April 12, 2025 23:48
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Apr 12, 2025
Copy link
Contributor

openshift-ci bot commented Apr 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/helm Related to helm-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared plugin-api-changed Categorizes a PR as containing plugin API changes labels Apr 12, 2025
@logonoff
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2025
@logonoff logonoff changed the title CONSOLE-4492: Use PF component group for PageHeader CONSOLE-4492: Use PF component group for PageHeading Apr 13, 2025
@logonoff
Copy link
Member Author

qe review:
/assign @yapei

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 13, 2025

@logonoff: This pull request references CONSOLE-4492 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com//browse/CONSOLE-4492

follow up on #14875

adopts PF PageHeader for console's main heading component.

no major UI changes should appear in this PR (e.g., create buttons appearing in a separate row as the title), except for two: operator details now have a line between the operator icon and the operator name. badges are also now placed next to the title.

fixes small a11y issue where heading actions were inside of the h1 element when it shouldn't be

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Apr 13, 2025
@yapei
Copy link
Contributor

yapei commented Apr 14, 2025

  • Check Edit YAML link and style on StorageClass, VolumeSnapshot, PersistentVolumeClaim creation page
    Screenshot 2025-04-14 at 3 26 18 PM
  • Check resource detail page when a badge is present, such as pod details page
Screenshot 2025-04-14 at 5 25 50 PM - Check operator details page heading Screenshot 2025-04-14 at 5 29 44 PM - Also tested against Chrome, Safari, iPhone devices

No outstanding layout issues found
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 14, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 14, 2025

@logonoff: This pull request references CONSOLE-4492 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com//browse/CONSOLE-4492

follow up on #14875

adopts PF PageHeader for console's main heading component.

no major UI changes should appear in this PR (e.g., create buttons appearing in a separate row as the title), except for two: operator details now have a line between the operator icon and the operator name. badges are also now placed next to the title.

fixes small a11y issue where heading actions were inside of the h1 element when it shouldn't be

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 21, 2025
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-54670, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/monitoring Related to monitoring component/topology Related to topology labels Apr 21, 2025
@openshift-ci openshift-ci bot requested a review from yapei April 21, 2025 15:57
@logonoff logonoff force-pushed the pageheader branch 3 times, most recently from a678243 to 1293485 Compare April 22, 2025 01:12
@rhamilto
Copy link
Member

/retest

@nicolethoen
Copy link
Member

let's ask @nicolethoen for guidance here 👀

Did you all sort this out? I know i merged a PR in component groups which likely relates to this?

@openshift-ci openshift-ci bot added the kind/cypress Related to Cypress e2e integration testing label Apr 22, 2025
@rhamilto
Copy link
Member

let's ask @nicolethoen for guidance here 👀

Did you all sort this out? I know i merged a PR in component groups which likely relates to this?

Yes, we did. Thank you!

@logonoff logonoff force-pushed the pageheader branch 3 times, most recently from 9be97bc to 00fe770 Compare April 22, 2025 23:30
@openshift-ci openshift-ci bot added the component/dashboard Related to dashboard label Apr 22, 2025
@logonoff logonoff force-pushed the pageheader branch 4 times, most recently from 071e917 to 03dc8ea Compare April 23, 2025 03:18
logonoff and others added 7 commits April 22, 2025 23:53
- adopt `BasePageHeading` when possible (as many pages don't use the extra functionality provided by the `connect`)
- Rename `PageHeading` to `ConnectedPageHeading`
- Rename `BasePageHeading` to `PageHeading`
- move `PageHeading`, `Breadcrumbs` to console/shared
- update cypress test to reflect changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/knative Related to knative-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated plugin-api-changed Categorizes a PR as containing plugin API changes px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants