Skip to content

OCPBUGS-55047: align spacing after breadrcumb with PatternFly #14972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2025
Merged

OCPBUGS-55047: align spacing after breadrcumb with PatternFly #14972

merged 1 commit into from
Apr 19, 2025

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Apr 15, 2025 •
edited
Loading

After

Screenshot 2025-04-15 at 5 17 46 PM Screenshot 2025-04-15 at 5 17 50 PM Screenshot 2025-04-15 at 5 17 53 PM

@PeterYurkovich, you're going to need to account for the removal of .monitoring-breadcrumbs. .pf-v6-u-pb-md is an easy subtitute.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 15, 2025
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-55047, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

After

Screenshot 2025-04-15 at 5 17 46 PM Screenshot 2025-04-15 at 5 17 50 PM Screenshot 2025-04-15 at 5 17 53 PM

@PeterYurkovich, you're going to need to account for the removal of .monitoring-breadcrumbs. .pf-v6-u-pb-sm is an easy subtitute.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 15, 2025
@openshift-ci openshift-ci bot requested review from yapei, kyoto and Mylanos April 15, 2025 21:29
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/monitoring Related to monitoring approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 15, 2025
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-55047, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

After

Screenshot 2025-04-15 at 5 17 46 PM Screenshot 2025-04-15 at 5 17 50 PM Screenshot 2025-04-15 at 5 17 53 PM

@PeterYurkovich, you're going to need to account for the removal of .monitoring-breadcrumbs. .pf-v6-u-pb-md is an easy subtitute.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jhadvig
jhadvig approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 678ea5f and 2 for PR HEAD e17ec93 in total

@rhamilto
Copy link
Member Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Apr 16, 2025
@rhamilto
Copy link
Member Author

/test e2e-gcp-console

@rhamilto
Copy link
Member Author

/retest

1 similar comment
@rhamilto
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 774f5ed and 2 for PR HEAD e17ec93 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7569675 and 2 for PR HEAD e17ec93 in total

@rhamilto
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 19, 2025

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a71cf39 into openshift:main Apr 19, 2025
8 checks passed
@openshift-ci-robot
Copy link
Contributor

@rhamilto: Jira Issue OCPBUGS-55047: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55047 has been moved to the MODIFIED state.

In response to this:

After

Screenshot 2025-04-15 at 5 17 46 PM Screenshot 2025-04-15 at 5 17 50 PM Screenshot 2025-04-15 at 5 17 53 PM

@PeterYurkovich, you're going to need to account for the removal of .monitoring-breadcrumbs. .pf-v6-u-pb-md is an easy subtitute.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.19.0-202504191511.p0.ga71cf39.assembly.stream.el9.
All builds following this will include this PR.

@rhamilto rhamilto deleted the OCPBUGS-55047 branch April 19, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@yapei yapei Awaiting requested review from yapei

@kyoto kyoto Awaiting requested review from kyoto

@Mylanos Mylanos Awaiting requested review from Mylanos

Assignees

@jhadvig jhadvig

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhamilto @openshift-ci-robot @openshift-bot @jhadvig